fix inspection for structs that use the StructMeta metaclass (#941)#945
fix inspection for structs that use the StructMeta metaclass (#941)#945ofek merged 6 commits intojcrist:mainfrom
StructMeta metaclass (#941)#945Conversation
|
Thanks! Have you confirmed that this also fixes the second comment in that issue? It appears to be a different error. |
|
Ah, I didn't see that a second comment was added! I'll take a look at this as well and update this PR |
|
Do you have an estimate on when you might be able to check? I was planning on releasing in a few hours. |
|
I've fixed |
|
I added another test to confirm the expected behavior! |
|
@ofek seems like that test you added uncovered another case that was still buggy. I've pushed an additional fix for that. I've got the feeling though that there might still have some cases left elsewhere in the library where |
|
I pushed some code changes and a doc update. What we want to express in the type system currently is not possible, example discussion in python/typing#1489. |
ofek
left a comment
There was a problem hiding this comment.
Thanks a lot for taking the initiative here!
Allow
msgspec.structs.fieldon types that usemetaclass=StructMeta.Fixes #941.