fix(s3): fix reverse release ordering#173
Merged
GideonBear merged 1 commit intojaemk:masterfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
|
Another way to do this is to keep the current sorting code and do a |
Collaborator
|
Does that mean this was always broken? |
Collaborator
|
Can you show the before/after behavior? |
Contributor
Author
|
I think it was probably always broken yes :( My code calling this is: self_update::backends::s3::Update::configure()
.end_point(self_update::backends::s3::EndPoint::Generic {
end_point: "https://lb01-s3-swf.example.com/softs/".to_owned(),
})
.bucket_name("softs")
.asset_prefix("lake-upload")
.access_key_id(env!("AWS_ACCESS_KEY_ID"))
.secret_access_key(env!("AWS_SECRET_ACCESS_KEY"))
.show_download_progress(true)
.current_version("1.0.0")
// .current_version(cargo_crate_version!()) TODO: put back
.bin_name("lake-upload")
.show_output(true)
.no_confirm(false)
.build()?
.update_extended()?With the current behavior, (and RUST_LOG=debug) I get this: And with my patch, I get: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update_extendedcode expects the return of get_latest_releases to be in descending order, that is, the latest release is first. (as it does acompatible_releases.first().cloned())This why this looks kinda reversed.