Parse Kotlin SMAP only once for each class#2114
Merged
Merged
Conversation
marchof
reviewed
May 10, 2026
marchof
reviewed
May 10, 2026
| final String[] exceptions) { | ||
|
|
||
| if (sourceDebugExtension != null && Filters.isKotlinClass(this)) { | ||
| // Note that visitSource is invoked before visitAnnotation, |
Member
There was a problem hiding this comment.
In this context but for a separate PR to improve readablity: Maybe our ASM *Visitor implementations should have the visit*() methods always in the source files ordered like the call sequence defined by ASM.
marchof
reviewed
May 11, 2026
marchof
reviewed
May 11, 2026
marchof
reviewed
May 11, 2026
marchof
reviewed
May 11, 2026
Godin
commented
May 11, 2026
marchof
reviewed
May 11, 2026
| mv.accept(mn, mv); | ||
| analyzer.visitAnnotation("Lkotlin/Metadata;", false); | ||
| fail("exception expected"); | ||
| } catch (Exception e) { |
Member
There was a problem hiding this comment.
Should we test for the specific exception type?
Suggested change
| } catch (Exception e) { | |
| } catch (IllegalStateException e) { |
marchof
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.