Skip to content

ColumnTypeLength method return the type length for varbit type.#2448

Merged
jackc merged 1 commit intojackc:masterfrom
DengChan:column_type_lenth_varbit
Dec 26, 2025
Merged

ColumnTypeLength method return the type length for varbit type.#2448
jackc merged 1 commit intojackc:masterfrom
DengChan:column_type_lenth_varbit

Conversation

@DengChan
Copy link
Contributor

@DengChan DengChan commented Dec 9, 2025

@jackc
Copy link
Owner

jackc commented Dec 13, 2025

Seems reasonable. But can you add some tests showing that it works?

@DengChan DengChan force-pushed the column_type_lenth_varbit branch from 4b4dac1 to 5736d09 Compare December 21, 2025 15:47
@DengChan
Copy link
Contributor Author

Seems reasonable. But can you add some tests showing that it works?

Sure!
I add test case TestRowsColumnTypeLength in stdlib/sql_test.go, and the case passed as expected.

@jackc jackc merged commit 2cf78dd into jackc:master Dec 26, 2025
2 of 14 checks passed
@jackc
Copy link
Owner

jackc commented Dec 26, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants