Add `pretty_format_json` as builtin hook by feliblo · Pull Request #915 · j178/prek

feliblo · 2025-10-17T09:59:50Z

Description

Following the information provided in 880. This is an implementation of the pretty-format-json hook.

The pretty-format-json has 1k grep.app hits. It's the final unimplemented hook used by airflow as mentioned in this comment.

Notes

Preserve JSON Order
- Added the preserve_order feature to serde_json. This prevents serde from automatically ordering JSON data, which is important for comparisons with older implementations.
- This change does not appear to affect other tests/features.
- By default, serde uses a BTreeMap for Object. Enabling preserve_order switches it to IndexMap.
- This keeps the sorting logic within the sort-keys argument.
Git-Style Diff with similar
- Added the similar library to perform git-style diff checks.
- Binary size increase is minimal.
- Useful as a general utility and could be leveraged in other parts of the project, maybe needed to be relocated?
- Added color highlighting to the diffs, improving readability compared to original pre-commit.

cargo clean
cargo build --release

Master branch: 8.49 MB
Feature branch: 8.55 MB
+66,176 bytes (+0.74%) increase from master to feature branch

Q: why is my size so much smaller than both sizes mentioned here?

Performance

Ran these commands on the airflow repository:

# old
pre-commit run pretty-format-json --all-files --verbose
Format JSON files........................................................Passed
- hook id: pretty-format-json
- duration: 0.03s

# Old prek implementation (python)
prek run pretty-format-json --all-files --verbose
Format JSON files........................................................Passed
- hook id: pretty-format-json
- duration: 0.03s

# New implementation (rust)
prek run pretty-format-json --all-files --verbose
Format JSON files........................................................Passed
- hook id: pretty-format-json
- duration: 0.00s

Output

Old pre-commit:

New:

Where both would autofix to the same:

codecov · 2025-10-17T11:55:10Z

Codecov Report

❌ Patch coverage is 99.65870% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.14%. Comparing base (dbca904) to head (839a050).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
...k/src/hooks/pre_commit_hooks/pretty_format_json.rs	99.65%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
+ Coverage   91.93%   92.14%   +0.20%     
==========================================
  Files         107      108       +1     
  Lines       21164    21750     +586     
==========================================
+ Hits        19458    20042     +584     
- Misses       1706     1708       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lmmx · 2025-10-17T16:46:59Z

Not sure why our binary sizes don't match, a good idea would be to have this computed on CI (I know CodeCov can do that automatically for JavaScript bundles or something? But not sure about Rust)

Will open an issue about that, but relative size like you did is fine 👍

Binary size reporting on CI #917

Edit: oh, did you build in release mode? I doubt it would matter though

I thought similar was the same crate difftastic uses but that is strsim

It says there is a testing crate for it https://github.com/mitsuhiko/similar-asserts maybe that could simplify the tests, but no need to

feliblo · 2025-10-17T16:57:39Z

@lmmx Yes I did, assumed you did aswell fom this snippet:

louis 🌟 ~/dev/prek $ du -h target/release/prek; echo; du target/release/prek
12M     target/release/prek

11920   target/release/prek

feliblo · 2025-10-17T17:12:35Z

@lmmx I'll take a look at simplifying the tests. Could also assign a new issue to me, so I can pick it up later on, when time allows

lmmx · 2025-10-17T18:47:50Z

@lmmx I'll take a look at simplifying the tests. Could also assign a new issue to me, so I can pick it up later on, when time allows

All good! Just FYI, you don't need to be assigned anything to work on it here. Open source repos work on a pull-based model where contributors pick up issues they want to work on. I'm just another contributor here, not a maintainer, so I can't assign tickets anyway 😁

My comment was just a suggestion if you were after any more ideas, feel free to leave it as is. Enjoy your weekend 😄

j178 · 2025-10-17T22:01:47Z

Not sure why our binary sizes don't match

I think you might be on different operating systems or architectures?

feliblo · 2025-10-17T22:18:50Z

Arm, macbook here! Didnt think it would be such a difference. Like the ci suggestion!

lmmx · 2025-10-18T08:38:48Z

Arm, macbook here! Didnt think it would be such a difference. Like the ci suggestion!

Linux, no I didn't expect it to be such a gap either

github-actions · 2025-10-22T13:38:19Z

📦 Cargo Bloat Comparison

Binary size change: +1.60% (25.0 MiB → 25.4 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  82.5KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  75.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  71.2KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  46.0KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.2KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.6KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  26.3KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.0KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.7KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.5%  86.2%  10.5MiB                   And 23909 smaller methods. Use -n N to show more.
48.2% 100.0%  12.2MiB                   .text section size, the file size is 25.4MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  81.3KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  74.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  47.1KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.2KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  24.4KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.1KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.8KiB              prek prek::main
41.4%  86.0%  10.3MiB                   And 23388 smaller methods. Use -n N to show more.
48.1% 100.0%  12.0MiB                   .text section size, the file size is 25.0MiB

feliblo · 2025-10-25T14:14:14Z

@j178 Anything I can add to this PR? I checked the similar-asserts crate, but didn't find it cleaned up tests more than simple test files, like it has at the moment. If you still prefer the other way, I'm happy to change it.

j178 · 2025-10-25T18:06:13Z

Your work is fantastic - the rest is on my end now. I just need more time to figure out all the details and make sure everything lines up with the Python implementation. If I think anything needs tweaking, I’ll make adjustments based on what you’ve built. Thanks for all your hard work!

Copilot

Pull request overview

Adds a new builtin implementation of the pretty-format-json hook to close a remaining gap in pre-commit-hooks parity, including formatting behavior, diff output, docs, schema updates, and test coverage.

Changes:

Implement pretty-format-json as a repo: builtin hook (intentionally not enabled for automatic fast-path replacement of the upstream Python hook yet).
Add documentation + schema + builtin listing updates to expose the new hook.
Add integration/unit tests and introduce the similar dependency for diff rendering.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`prek.schema.json`	Allows `pretty-format-json` as a valid builtin hook id in the schema.
`docs/builtin.md`	Documents the new hook, its supported args, and current availability caveats.
`crates/prek/tests/list_builtins.rs`	Ensures builtin listing output includes `pretty-format-json`.
`crates/prek/tests/builtin_hooks.rs`	Adds end-to-end integration tests for formatting/autofix/options.
`crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs`	New hook implementation: parse/reorder/format JSON, optional autofix, and diff output.
`crates/prek/src/hooks/pre_commit_hooks/mod.rs`	Wires the new module and export for hook dispatch.
`crates/prek/src/hooks/builtin_hooks/mod.rs`	Registers the new builtin hook and its metadata/types/stages.
`crates/prek/Cargo.toml`	Adds `similar` as a dependency for the `prek` crate.
`Cargo.toml`	Adds `similar` to workspace dependencies.
`Cargo.lock`	Locks the new dependency.

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs

crates/prek/tests/builtin_hooks.rs

prek-ci-bot · 2026-03-22T14:38:01Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.14.0-1017-azure
CPU: 4 cores
prek version: prek 0.3.6+34 (80bfd93 2026-03-23)
Rust version: rustc 1.94.0 (4a4ef493e 2026-03-02)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.4 ± 0.1	2.2	3.1	1.04 ± 0.07
`prek-head --version`	2.3 ± 0.1	2.2	2.8	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	9.2 ± 2.6	8.7	34.3	1.03 ± 0.29
`prek-head list`	8.9 ± 0.1	8.7	9.5	1.00

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.2 ± 0.0	3.1	3.3	1.01 ± 0.02
`prek-head validate-config .pre-commit-config.yaml`	3.2 ± 0.0	3.1	3.2	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.7 ± 0.2	2.6	3.7	1.02 ± 0.06
`prek-head sample-config`	2.6 ± 0.0	2.5	2.8	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	156.6 ± 4.5	151.9	164.4	1.01 ± 0.04
`prek-head run --all-files`	154.7 ± 3.3	152.0	162.4	1.00

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	155.0 ± 4.1	149.9	167.6	1.00
`prek-head run --all-files`	155.2 ± 2.4	150.8	159.3	1.00 ± 0.03

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	155.7 ± 3.8	151.2	175.4	1.00
`prek-head run --all-files`	159.7 ± 19.8	151.9	288.2	1.03 ± 0.13

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	21.9 ± 0.4	21.0	22.7	1.02 ± 0.03
`prek-head run trailing-whitespace --all-files`	21.6 ± 0.4	20.7	22.6	1.00

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	27.8 ± 1.5	25.2	30.7	1.00
`prek-head run end-of-file-fixer --all-files`	27.9 ± 1.6	25.5	31.9	1.00 ± 0.08

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	12.7 ± 0.5	11.5	13.8	1.05 ± 0.05
`prek-head run check-json --all-files`	12.1 ± 0.2	11.8	12.6	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	12.0 ± 0.3	11.6	12.7	1.02 ± 0.03
`prek-head run check-yaml --all-files`	11.8 ± 0.2	11.5	12.3	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	12.1 ± 0.3	11.6	13.2	1.01 ± 0.03
`prek-head run check-toml --all-files`	12.0 ± 0.2	11.5	12.4	1.00

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	12.2 ± 0.3	11.5	13.0	1.00 ± 0.04
`prek-head run check-xml --all-files`	12.2 ± 0.3	11.5	12.7	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	18.5 ± 1.1	17.0	21.2	1.02 ± 0.10
`prek-head run detect-private-key --all-files`	18.2 ± 1.4	16.6	22.5	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	23.6 ± 1.6	21.1	26.9	1.00 ± 0.09
`prek-head run fix-byte-order-marker --all-files`	23.6 ± 1.4	20.5	26.8	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.8 ± 0.1	4.7	4.9	1.00 ± 0.02
`prek-head install-hooks`	4.8 ± 0.0	4.7	4.8	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.8 ± 0.1	4.7	4.8	1.00
`prek-head install-hooks`	4.8 ± 0.1	4.7	4.9	1.01 ± 0.02

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	52.8 ± 1.1	51.6	56.8	1.00
`prek-head run`	53.7 ± 1.4	51.7	57.0	1.02 ± 0.03

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	9.1 ± 0.1	8.9	9.3	1.01 ± 0.02
`prek-head run --files '*.json'`	9.0 ± 0.1	8.9	9.3	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	14.2 ± 0.9	13.8	17.8	1.02 ± 0.06
`prek-head run --dry-run --all-files`	13.9 ± 0.1	13.7	14.2	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	13.6 ± 0.7	12.5	14.3	1.08 ± 0.06
`prek-head run check-hooks-apply --all-files`	12.6 ± 0.1	12.5	13.0	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	12.5 ± 0.1	12.3	12.8	1.00
`prek-head run check-useless-excludes --all-files`	12.6 ± 0.1	12.4	12.7	1.00 ± 0.01

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	11.0 ± 0.1	10.7	11.2	1.00
`prek-head run identity --all-files`	11.1 ± 0.1	10.9	11.2	1.01 ± 0.01

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs

crates/prek/tests/builtin_hooks.rs

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs

j178 · 2026-03-23T06:59:10Z

Finally, let’s merge, thanks so much for your work!

feliblo · 2026-03-24T15:40:24Z

Completely forgot about this haha! Great to see!

feliblo changed the title ~~feat: implement pretty_format_json~~ feat: (pretty_format_json) implement builtin hook Oct 17, 2025

feliblo closed this Oct 17, 2025

feliblo reopened this Oct 17, 2025

feliblo force-pushed the pretty_format_json branch from 897d3f3 to ae79e95 Compare October 17, 2025 11:52

feliblo force-pushed the pretty_format_json branch from ae79e95 to 386ebd2 Compare October 17, 2025 12:00

feliblo mentioned this pull request Oct 17, 2025

[perf] Port more pre-commit hooks #880

Closed

34 tasks

lmmx mentioned this pull request Oct 17, 2025

Binary size reporting on CI #917

Closed

feliblo mentioned this pull request Oct 18, 2025

[bug] parse_shebang can return an empty list #925

Closed

j178 changed the title ~~feat: (pretty_format_json) implement builtin hook~~ Implement pretty_format_json as builtin hook Oct 20, 2025

j178 added the enhancement New feature or request label Oct 20, 2025

feliblo force-pushed the pretty_format_json branch 2 times, most recently from 333ae62 to 107da9e Compare October 22, 2025 13:28

j178 force-pushed the master branch from 0573b0f to 549f3ae Compare January 7, 2026 14:45

j178 self-requested a review as a code owner February 5, 2026 09:44

j178 force-pushed the pretty_format_json branch from 107da9e to 03d9478 Compare March 22, 2026 14:30

Copilot AI review requested due to automatic review settings March 22, 2026 14:30

feliblo and others added 2 commits March 22, 2026 22:30

feat: implement pretty_format_json

760772d

Add builtin pretty-format-json hook

f4722c7

Copilot started reviewing on behalf of j178 March 22, 2026 14:30 View session

j178 force-pushed the pretty_format_json branch from 03d9478 to f4722c7 Compare March 22, 2026 14:30

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 22, 2026 17:05

Copilot started reviewing on behalf of j178 March 22, 2026 17:06 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Style improvement

4190d44

j178 force-pushed the pretty_format_json branch from 9a7ea0d to ac0c55d Compare March 23, 2026 06:23

Refine pretty-format-json key ordering

0309e6d

Copilot AI review requested due to automatic review settings March 23, 2026 06:24

j178 force-pushed the pretty_format_json branch from ac0c55d to 0309e6d Compare March 23, 2026 06:24

Copilot started reviewing on behalf of j178 March 23, 2026 06:24 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs Outdated Show resolved Hide resolved

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs Outdated Show resolved Hide resolved

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs Outdated Show resolved Hide resolved

Prepare pretty-format-json args once

3f88121

j178 changed the title ~~Implement pretty_format_json as builtin hook~~ Add pretty_format_json as builtin hook Mar 23, 2026

Tweak

839a050

Copilot AI review requested due to automatic review settings March 23, 2026 06:52

Copilot started reviewing on behalf of j178 March 23, 2026 06:53 View session

j178 merged commit ba62c04 into j178:master Mar 23, 2026
56 checks passed

Copilot AI reviewed Mar 23, 2026

View reviewed changes

crates/prek/src/hooks/pre_commit_hooks/pretty_format_json.rs Show resolved Hide resolved

BrewTestBot mentioned this pull request Mar 23, 2026

prek 0.3.8 Homebrew/homebrew-core#273730

Merged

Conversation

feliblo commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes

Performance

Output

Uh oh!

codecov bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lmmx commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feliblo commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feliblo commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmmx commented Oct 17, 2025

Uh oh!

j178 commented Oct 17, 2025

Uh oh!

feliblo commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lmmx commented Oct 18, 2025

Uh oh!

github-actions bot commented Oct 22, 2025 • edited by prek-ci-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

feliblo commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

j178 commented Oct 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prek-ci-bot bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

feliblo commented Oct 17, 2025 •

edited

Loading

codecov bot commented Oct 17, 2025 •

edited

Loading

lmmx commented Oct 17, 2025 •

edited

Loading

feliblo commented Oct 17, 2025 •

edited

Loading

feliblo commented Oct 17, 2025 •

edited

Loading

feliblo commented Oct 17, 2025 •

edited

Loading

github-actions bot commented Oct 22, 2025 •

edited by prek-ci-bot bot

Loading

feliblo commented Oct 25, 2025 •

edited

Loading

prek-ci-bot bot commented Mar 22, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`