Fix workspace-relative added file paths by j178 · Pull Request #1852 · j178/prek

j178 · 2026-03-22T13:16:47Z

Fix workspace relative path for check-case-conflict and check-added-large-files

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ae2cb46c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/prek/src/hooks/pre_commit_hooks/destroyed_symlinks.rs

prek-ci-bot · 2026-03-22T13:20:50Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (25.0 MiB → 25.0 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  81.3KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  74.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  47.1KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.2KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  24.4KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.1KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.8KiB              prek prek::main
41.4%  86.0%  10.3MiB                   And 23388 smaller methods. Use -n N to show more.
48.1% 100.0%  12.0MiB                   .text section size, the file size is 25.0MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_39_0_aes_gcm_decrypt_avx512
 0.3%   0.7%  81.3KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  74.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.1KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.9KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  47.1KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_39_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.2KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  25.4KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  24.4KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.1KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.8KiB              prek prek::main
41.4%  86.0%  10.3MiB                   And 23388 smaller methods. Use -n N to show more.
48.1% 100.0%  12.0MiB                   .text section size, the file size is 25.0MiB

Copilot

Pull request overview

This PR extends prek’s builtin hook set and improves workspace-mode path handling so hooks operate on project-relative filenames correctly, even in nested projects.

Changes:

Added support for the destroyed-symlinks builtin hook (implementation, docs, schema, and list-builtins output).
Fixed workspace-mode path semantics for staged “added files” and git-lfs attribute lookups (project-relative).
Added/updated integration tests covering the new hook and the workspace-relative path regressions.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
prek.schema.json	Adds `destroyed-symlinks` to the allowed builtin hook IDs in the JSON schema.
docs/builtin.md	Documents the new `destroyed-symlinks` hook and includes it in builtin hook lists.
crates/prek/tests/list_builtins.rs	Updates snapshots so `list-builtins` outputs include `destroyed-symlinks`.
crates/prek/tests/builtin_hooks.rs	Adds regression tests for workspace-mode path handling and adds a test for `destroyed-symlinks`.
crates/prek/src/hooks/pre_commit_hooks/mod.rs	Wires the new `destroyed_symlinks` fast-path hook module into the dispatcher.
crates/prek/src/hooks/pre_commit_hooks/destroyed_symlinks.rs	Implements the `destroyed-symlinks` hook logic via `git status` + blob comparisons.
crates/prek/src/hooks/pre_commit_hooks/check_added_large_files.rs	Runs git-lfs attribute lookup from the project root to respect nested `.gitattributes`.
crates/prek/src/hooks/builtin_hooks/mod.rs	Registers the `destroyed-symlinks` builtin hook (id/name/entry/metadata).
crates/prek/src/git.rs	Makes `get_added_files` project-relative in subdirectories and adds `current_dir` to `get_lfs_files`.

crates/prek/tests/builtin_hooks.rs

prek-ci-bot · 2026-03-22T13:29:46Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.14.0-1017-azure
CPU: 4 cores
prek version: prek 0.3.6+36 (f2c8875 2026-03-22)
Rust version: rustc 1.94.0 (4a4ef493e 2026-03-02)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.4 ± 0.1	2.2	2.8	1.00
`prek-head --version`	2.4 ± 0.1	2.2	3.2	1.01 ± 0.06

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	9.3 ± 0.2	8.8	9.8	1.00
`prek-head list`	9.5 ± 0.3	9.0	11.5	1.02 ± 0.04

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.3 ± 0.1	3.2	3.7	1.01 ± 0.04
`prek-head validate-config .pre-commit-config.yaml`	3.3 ± 0.1	3.2	3.5	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.7 ± 0.0	2.6	2.8	1.00
`prek-head sample-config`	2.7 ± 0.2	2.6	3.9	1.01 ± 0.07

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	162.5 ± 4.5	155.9	169.0	1.00
`prek-head run --all-files`	163.1 ± 2.6	160.1	168.8	1.00 ± 0.03

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	161.3 ± 5.9	154.4	181.9	1.00
`prek-head run --all-files`	167.1 ± 4.2	162.2	179.8	1.04 ± 0.05

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	164.6 ± 4.7	154.1	172.8	1.00 ± 0.08
`prek-head run --all-files`	164.5 ± 11.7	153.7	238.9	1.00

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	23.9 ± 0.8	22.8	25.6	1.00
`prek-head run trailing-whitespace --all-files`	24.2 ± 0.6	22.9	25.4	1.01 ± 0.04

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	31.0 ± 2.0	27.6	34.4	1.01 ± 0.09
`prek-head run end-of-file-fixer --all-files`	30.7 ± 1.8	28.0	34.3	1.00

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	13.0 ± 0.5	12.2	14.0	1.00
`prek-head run check-json --all-files`	13.2 ± 0.5	12.6	14.2	1.02 ± 0.05

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	13.6 ± 0.7	12.7	15.2	1.06 ± 0.06
`prek-head run check-yaml --all-files`	12.8 ± 0.3	12.1	13.5	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	12.5 ± 0.3	12.0	13.4	1.00
`prek-head run check-toml --all-files`	12.5 ± 0.3	11.7	13.2	1.00 ± 0.04

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	12.8 ± 0.5	12.1	14.3	1.04 ± 0.05
`prek-head run check-xml --all-files`	12.3 ± 0.3	11.8	13.0	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	20.0 ± 1.0	17.9	22.2	1.02 ± 0.09
`prek-head run detect-private-key --all-files`	19.7 ± 1.5	17.0	22.6	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	25.3 ± 1.8	22.3	28.2	1.02 ± 0.10
`prek-head run fix-byte-order-marker --all-files`	25.0 ± 1.7	22.4	28.5	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	5.1 ± 0.0	5.0	5.1	1.00 ± 0.03
`prek-head install-hooks`	5.1 ± 0.2	4.9	5.3	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	5.0 ± 0.1	4.9	5.2	1.00 ± 0.03
`prek-head install-hooks`	5.0 ± 0.0	5.0	5.0	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	54.7 ± 1.5	52.6	58.1	1.01 ± 0.03
`prek-head run`	54.4 ± 1.2	53.2	57.6	1.00

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	9.4 ± 0.1	9.2	9.6	1.00 ± 0.03
`prek-head run --files '*.json'`	9.4 ± 0.2	9.1	9.9	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	14.7 ± 0.3	14.3	15.3	1.00
`prek-head run --dry-run --all-files`	15.7 ± 1.8	14.7	23.0	1.07 ± 0.12

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	14.4 ± 0.2	14.2	14.8	1.05 ± 0.07
`prek-head run check-hooks-apply --all-files`	13.8 ± 0.9	12.7	15.4	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	12.8 ± 0.4	12.5	13.9	1.00
`prek-head run check-useless-excludes --all-files`	13.3 ± 0.2	12.9	13.7	1.04 ± 0.04

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	11.6 ± 0.2	11.4	11.9	1.00 ± 0.02
`prek-head run identity --all-files`	11.6 ± 0.2	11.4	12.1	1.00

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef76f9e7ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/prek/src/git.rs

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

crates/prek/tests/builtin_hooks.rs

This reverts commit ef76f9e.

codecov · 2026-03-22T14:34:54Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.98%. Comparing base (24f2d62) to head (9b9770d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1852      +/-   ##
==========================================
+ Coverage   91.93%   91.98%   +0.04%     
==========================================
  Files         107      107              
  Lines       21159    21164       +5     
==========================================
+ Hits        19452    19467      +15     
+ Misses       1707     1697      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

j178 and others added 5 commits March 22, 2026 13:51

Add new feature

00f79c7

Improve

b93fea1

Update crates/prek/src/hooks/builtin_hooks/mod.rs

de91012

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update docs/builtin.md

3a79c5b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Improve

ad7b40f

Copilot AI review requested due to automatic review settings March 22, 2026 13:16

j178 changed the title ~~fix/large file~~ Fix workspace-relative added file paths Mar 22, 2026

j178 added the bug Something isn't working label Mar 22, 2026

Fix workspace-relative added file paths

2153ece

Copilot started reviewing on behalf of j178 March 22, 2026 13:17 View session

j178 force-pushed the fix/large-file branch from 4ae2cb4 to 2153ece Compare March 22, 2026 13:17

j178 changed the base branch from master to feat/implement-destroyed-symlinks March 22, 2026 13:18

Base automatically changed from feat/implement-destroyed-symlinks to master March 22, 2026 13:19

Merge branch 'master' into fix/large-file

500da17

chatgpt-codex-connector bot reviewed Mar 22, 2026

View reviewed changes

crates/prek/src/hooks/pre_commit_hooks/destroyed_symlinks.rs Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 22, 2026

View reviewed changes

crates/prek/tests/builtin_hooks.rs Show resolved Hide resolved

Ensure failure

ef76f9e

chatgpt-codex-connector bot reviewed Mar 22, 2026

View reviewed changes

crates/prek/src/git.rs Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 22, 2026 13:35

Copilot started reviewing on behalf of j178 March 22, 2026 13:35 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

crates/prek/tests/builtin_hooks.rs Show resolved Hide resolved

Revert "Ensure failure"

9b9770d

This reverts commit ef76f9e.

j178 force-pushed the fix/large-file branch from cd325d7 to 9b9770d Compare March 22, 2026 13:45

j178 merged commit dbca904 into master Mar 22, 2026
51 checks passed

j178 deleted the fix/large-file branch March 22, 2026 13:50

BrewTestBot mentioned this pull request Mar 23, 2026

prek 0.3.8 Homebrew/homebrew-core#273730

Merged

Conversation

j178 commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

prek-ci-bot bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

prek-ci-bot bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

j178 commented Mar 22, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 22, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 22, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`

codecov bot commented Mar 22, 2026 •

edited

Loading