Relax alias-anchor ratio check for check-yaml by j178 · Pull Request #1839 · j178/prek

j178 · 2026-03-21T05:59:05Z

Disable serde-saphyr's alias/anchor ratio heuristic for the check-yaml hook while keeping the other parser budgets

codecov · 2026-03-21T06:00:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.78%. Comparing base (3ba2c1c) to head (425aa1b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1839   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         101      101           
  Lines       20565    20584   +19     
=======================================
+ Hits        18875    18894   +19     
  Misses       1690     1690

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR adjusts the check-yaml pre-commit hook’s YAML parser configuration to tolerate YAML files that use many aliases referencing few anchors (common in docker-compose style configs), while adding a regression test to ensure such files validate successfully.

Changes:

Disable serde-saphyr’s alias/anchor ratio enforcement specifically for the check-yaml hook by setting an explicit Budget.
Add a regression test that constructs YAML with many aliases and a single anchor and asserts it passes validation.

prek-ci-bot · 2026-03-21T06:04:58Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (24.9 MiB → 24.9 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  77.6KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  71.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  68.9KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  46.5KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.2KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  31.8KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.7KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  26.3KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.0KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.7KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.2%  86.0%  10.3MiB                   And 23393 smaller methods. Use -n N to show more.
47.9% 100.0%  11.9MiB                   .text section size, the file size is 24.9MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  77.6KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  71.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  68.9KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.2%   0.5%  56.8KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  46.5KiB              prek prek::run::{{closure}}
 0.2%   0.3%  42.2KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  31.8KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.7KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  26.3KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.2KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  23.0KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.7KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.2%  86.0%  10.3MiB                   And 23389 smaller methods. Use -n N to show more.
47.9% 100.0%  11.9MiB                   .text section size, the file size is 24.9MiB

prek-ci-bot · 2026-03-21T06:04:59Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.14.0-1017-azure
CPU: 4 cores
prek version: prek 0.3.6+20 (d2f6972 2026-03-21)
Rust version: rustc 1.94.0 (4a4ef493e 2026-03-02)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.4 ± 0.1	2.3	2.6	1.00
`prek-head --version`	2.4 ± 0.1	2.3	2.7	1.02 ± 0.04

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	9.8 ± 0.4	9.0	10.8	1.01 ± 0.06
`prek-head list`	9.7 ± 0.4	8.9	10.5	1.00

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.3 ± 0.1	3.1	3.6	1.03 ± 0.04
`prek-head validate-config .pre-commit-config.yaml`	3.2 ± 0.1	3.1	3.5	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.7 ± 0.1	2.6	2.9	1.01 ± 0.04
`prek-head sample-config`	2.7 ± 0.1	2.5	2.9	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	161.1 ± 1.6	159.2	163.5	1.00
`prek-head run --all-files`	163.1 ± 3.6	155.8	168.2	1.01 ± 0.02

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	159.8 ± 2.9	154.9	163.9	1.01 ± 0.03
`prek-head run --all-files`	157.7 ± 3.1	153.2	163.6	1.00

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	159.8 ± 4.5	152.7	171.5	1.00
`prek-head run --all-files`	164.1 ± 5.6	155.9	191.7	1.03 ± 0.05

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	23.3 ± 0.8	21.8	25.6	1.02 ± 0.05
`prek-head run trailing-whitespace --all-files`	22.8 ± 0.7	21.7	23.9	1.00

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	29.4 ± 1.8	26.0	32.6	1.00
`prek-head run end-of-file-fixer --all-files`	29.4 ± 1.8	26.3	33.8	1.00 ± 0.09

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	14.5 ± 1.4	12.4	17.3	1.15 ± 0.12
`prek-head run check-json --all-files`	12.6 ± 0.5	11.7	13.6	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	12.7 ± 0.3	12.3	13.4	1.01 ± 0.03
`prek-head run check-yaml --all-files`	12.5 ± 0.3	12.1	13.1	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	12.9 ± 0.5	12.3	14.3	1.00
`prek-head run check-toml --all-files`	13.1 ± 0.5	12.2	14.2	1.02 ± 0.05

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	12.8 ± 0.4	11.9	13.7	1.00
`prek-head run check-xml --all-files`	13.4 ± 0.5	12.7	14.6	1.04 ± 0.05

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	19.6 ± 1.6	17.3	23.2	1.00
`prek-head run detect-private-key --all-files`	19.7 ± 1.3	17.6	22.1	1.00 ± 0.11

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	25.1 ± 1.5	22.1	28.2	1.00
`prek-head run fix-byte-order-marker --all-files`	25.4 ± 1.4	22.1	27.5	1.01 ± 0.08

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	5.0 ± 0.1	4.9	5.0	1.00
`prek-head install-hooks`	5.2 ± 0.1	5.0	5.3	1.04 ± 0.02

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	5.0 ± 0.1	4.9	5.1	1.03 ± 0.02
`prek-head install-hooks`	4.8 ± 0.1	4.8	4.9	1.00

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	54.4 ± 1.4	52.7	58.7	1.00
`prek-head run`	54.9 ± 1.5	52.7	58.2	1.01 ± 0.04

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	9.7 ± 0.5	9.1	10.9	1.00
`prek-head run --files '*.json'`	9.8 ± 0.4	9.2	10.4	1.01 ± 0.07

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	14.9 ± 0.6	14.0	15.9	1.01 ± 0.07
`prek-head run --dry-run --all-files`	14.7 ± 0.8	14.0	16.8	1.00

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	14.7 ± 0.5	14.2	15.7	1.02 ± 0.05
`prek-head run check-hooks-apply --all-files`	14.4 ± 0.5	13.9	15.5	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	12.7 ± 0.3	12.3	13.4	1.00
`prek-head run check-useless-excludes --all-files`	12.9 ± 0.5	12.3	13.7	1.01 ± 0.05

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	11.4 ± 0.5	10.9	12.2	1.01 ± 0.05
`prek-head run identity --all-files`	11.3 ± 0.4	10.9	12.0	1.00

aldy505 · 2026-03-21T06:29:31Z

Thank you! I'll be waiting for the release :)

Relax alias-anchor ratio check for check-yaml

425aa1b

Copilot AI review requested due to automatic review settings March 21, 2026 05:59

Copilot started reviewing on behalf of j178 March 21, 2026 05:59 View session

Copilot AI reviewed Mar 21, 2026

View reviewed changes

j178 merged commit e5af7a1 into master Mar 21, 2026
57 checks passed

j178 deleted the yaml-limit branch March 21, 2026 06:06

BrewTestBot mentioned this pull request Mar 23, 2026

prek 0.3.8 Homebrew/homebrew-core#273730

Merged

Conversation

j178 commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

prek-ci-bot bot commented Mar 21, 2026

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot bot commented Mar 21, 2026

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Uh oh!

aldy505 commented Mar 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

j178 commented Mar 21, 2026 •

edited

Loading

codecov bot commented Mar 21, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`