Validate `uv` binary after download by j178 · Pull Request #1825 · j178/prek

j178 · 2026-03-19T03:35:53Z

Validate downloaded or installed uv binaries immediately after installation, to surface a clear message early.

For #1707

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 711ab79fbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/prek/src/languages/python/uv.rs

Copilot

Pull request overview

This PR aims to validate uv immediately after it’s installed/downloaded so that runtime incompatibility (e.g., libc / dynamic loader mismatches) is detected early and reported with a clearer error.

Changes:

Adds a post-install validation step to ensure the installed uv binary is executable and within the required version range.
Expands the inline comment and user-facing error message to better explain runtime incompatibility causes.

crates/prek/src/languages/python/uv.rs

prek-ci-bot · 2026-03-19T03:40:25Z

📦 Cargo Bloat Comparison

Binary size change: +0.00% (24.8 MiB → 24.8 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  73.1KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.0KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.6%  68.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  50.6KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  46.5KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  31.8KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.7KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  25.9KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.0KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.7KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  21.7KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.1%  86.0%  10.2MiB                   And 23308 smaller methods. Use -n N to show more.
47.8% 100.0%  11.9MiB                   .text section size, the file size is 24.8MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  73.1KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  69.0KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.6%  68.4KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  50.6KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  46.5KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  31.8KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  26.7KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  25.9KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  23.0KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  21.7KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  21.7KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.1%  86.0%  10.2MiB                   And 23305 smaller methods. Use -n N to show more.
47.8% 100.0%  11.9MiB                   .text section size, the file size is 24.8MiB

prek-ci-bot · 2026-03-19T03:40:26Z

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment

OS: Linux 6.14.0-1017-azure
CPU: 4 cores
prek version: prek 0.3.6+13 (d96df9b 2026-03-19)
Rust version: rustc 1.94.0 (4a4ef493e 2026-03-02)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.5 ± 0.1	2.3	2.9	1.01 ± 0.06
`prek-head --version`	2.5 ± 0.1	2.3	3.0	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	9.2 ± 0.1	9.0	9.7	1.00
`prek-head list`	9.4 ± 0.2	9.1	10.0	1.02 ± 0.02

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.2 ± 0.1	3.1	3.4	1.02 ± 0.03
`prek-head validate-config .pre-commit-config.yaml`	3.2 ± 0.1	3.1	3.3	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	3.0 ± 0.3	2.7	3.5	1.07 ± 0.12
`prek-head sample-config`	2.8 ± 0.2	2.6	3.4	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	161.3 ± 1.8	158.7	164.6	1.00
`prek-head run --all-files`	164.4 ± 3.6	159.7	170.7	1.02 ± 0.02

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	160.2 ± 3.6	155.1	167.0	1.00
`prek-head run --all-files`	162.6 ± 3.8	156.7	171.0	1.02 ± 0.03

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	162.9 ± 3.7	157.8	175.5	1.00
`prek-head run --all-files`	168.7 ± 21.7	158.2	303.9	1.04 ± 0.14

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	23.4 ± 0.4	22.5	24.4	1.01 ± 0.03
`prek-head run trailing-whitespace --all-files`	23.3 ± 0.6	22.4	25.3	1.00

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	30.2 ± 2.2	26.8	34.2	1.00
`prek-head run end-of-file-fixer --all-files`	30.4 ± 2.1	27.0	35.3	1.01 ± 0.10

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	13.2 ± 0.5	12.3	14.2	1.04 ± 0.05
`prek-head run check-json --all-files`	12.6 ± 0.3	12.1	13.3	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	12.7 ± 0.3	12.2	13.8	1.01 ± 0.03
`prek-head run check-yaml --all-files`	12.6 ± 0.3	12.1	13.2	1.00

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	12.9 ± 0.4	12.2	13.8	1.00
`prek-head run check-toml --all-files`	13.0 ± 0.3	12.5	13.6	1.00 ± 0.04

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	13.1 ± 0.4	12.4	14.2	1.01 ± 0.04
`prek-head run check-xml --all-files`	13.0 ± 0.3	12.5	13.8	1.00

`prek run detect-private-key --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run detect-private-key --all-files`	20.4 ± 1.8	18.1	26.1	1.02 ± 0.12
`prek-head run detect-private-key --all-files`	20.1 ± 1.6	17.6	23.2	1.00

`prek run fix-byte-order-marker --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run fix-byte-order-marker --all-files`	26.1 ± 1.8	22.8	29.3	1.02 ± 0.11
`prek-head run fix-byte-order-marker --all-files`	25.5 ± 2.0	22.0	29.1	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	5.2 ± 0.1	5.1	5.3	1.01 ± 0.02
`prek-head install-hooks`	5.1 ± 0.1	5.0	5.2	1.00

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	5.1 ± 0.1	5.0	5.1	1.00
`prek-head install-hooks`	5.2 ± 0.1	5.1	5.3	1.03 ± 0.02

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	54.6 ± 1.0	53.3	56.4	1.00
`prek-head run`	55.6 ± 1.3	53.7	58.2	1.02 ± 0.03

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	9.6 ± 0.1	9.4	9.9	1.00 ± 0.02
`prek-head run --files '*.json'`	9.6 ± 0.1	9.4	9.7	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	15.0 ± 0.2	14.6	15.6	1.00
`prek-head run --dry-run --all-files`	15.4 ± 1.7	14.6	22.6	1.02 ± 0.12

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	15.0 ± 0.3	14.6	15.8	1.10 ± 0.06
`prek-head run check-hooks-apply --all-files`	13.6 ± 0.6	13.1	14.8	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	13.2 ± 0.2	12.9	13.5	1.00
`prek-head run check-useless-excludes --all-files`	13.3 ± 0.3	12.9	13.7	1.00 ± 0.02

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	11.5 ± 0.1	11.3	11.7	1.00
`prek-head run identity --all-files`	11.6 ± 0.3	11.2	12.4	1.01 ± 0.03

codecov · 2026-03-19T04:07:18Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.71%. Comparing base (68e6fcb) to head (5aa6649).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
crates/prek/src/languages/python/uv.rs	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
- Coverage   91.72%   91.71%   -0.01%     
==========================================
  Files          98       98              
  Lines       20063    20067       +4     
==========================================
+ Hits        18403    18405       +2     
- Misses       1660     1662       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR improves the Python/uv toolchain bootstrap in prek by validating the managed uv binary immediately after installation, so incompatibilities (e.g., libc/loader mismatches) fail early with a clearer, actionable error message (addresses #1707).

Changes:

Validate the managed uv binary right after installation and emit a detailed failure message if it can’t execute or doesn’t meet the version range.
Minor refactor in platform-tag conversion (ToString::to_string).

crates/prek/src/languages/python/uv.rs

Copilot AI review requested due to automatic review settings March 19, 2026 03:35

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

crates/prek/src/languages/python/uv.rs Outdated Show resolved Hide resolved

j178 mentioned this pull request Mar 19, 2026

python: move uv tests into the test module #1824

Merged

Copilot AI reviewed Mar 19, 2026

View reviewed changes

crates/prek/src/languages/python/uv.rs Outdated Show resolved Hide resolved

crates/prek/src/languages/python/uv.rs Outdated Show resolved Hide resolved

j178 force-pushed the validate-uv branch from 711ab79 to 5e5780a Compare March 19, 2026 03:40

j178 added enhancement New feature or request error message Better error message python Pull requests that update python code labels Mar 19, 2026

Validate installed uv binaries

5aa6649

Copilot AI review requested due to automatic review settings March 19, 2026 04:08

j178 force-pushed the validate-uv branch from 5e5780a to 5aa6649 Compare March 19, 2026 04:08

Copilot AI reviewed Mar 19, 2026

View reviewed changes

crates/prek/src/languages/python/uv.rs Show resolved Hide resolved

crates/prek/src/languages/python/uv.rs Show resolved Hide resolved

j178 changed the title ~~Validate installed uv binaries~~ Validate uv binary after download Mar 19, 2026

j178 merged commit 65327f6 into master Mar 19, 2026
54 checks passed

j178 deleted the validate-uv branch March 19, 2026 05:07

BrewTestBot mentioned this pull request Mar 23, 2026

prek 0.3.8 Homebrew/homebrew-core#273730

Merged

Conversation

j178 commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

prek-ci-bot bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Benchmarks

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek run detect-private-key --all-files

prek run fix-byte-order-marker --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

codecov bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

j178 commented Mar 19, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 19, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 19, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek run detect-private-key --all-files`

`prek run fix-byte-order-marker --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`

codecov bot commented Mar 19, 2026 •

edited

Loading