Retry auth-failed repo clones with terminal prompts enabled by j178 · Pull Request #1761 · j178/prek

j178 · 2026-03-09T12:25:52Z

When a repo clone fails because authentication is required, retry that clone with GIT_TERMINAL_PROMPT=1 so Git can prompt the user for credentials.

The retry flow keeps the initial clone pass non-interactive, detects auth-related failures, and then retries only those failed clones with terminal prompts enabled. Retries run sequentially so users only see one credential prompt at a time and know which repository is requesting authentication.

Closes #1634
Closes #1173
Related #1193
Related #1472

codecov · 2026-03-09T12:28:05Z

Codecov Report

❌ Patch coverage is 67.85714% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.71%. Comparing base (3cd9382) to head (ee8d563).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
crates/prek/src/store.rs	56.48%	47 Missing ⚠️
crates/prek/src/git.rs	85.48%	9 Missing ⚠️
crates/prek/src/workspace.rs	65.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1761      +/-   ##
==========================================
- Coverage   91.76%   91.71%   -0.06%     
==========================================
  Files          98       98              
  Lines       19737    19847     +110     
==========================================
+ Hits        18112    18203      +91     
- Misses       1625     1644      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR improves remote repository cloning in prek by retrying authentication-related clone failures with interactive Git terminal prompts enabled, while keeping the initial cloning pass non-interactive and parallel.

Changes:

Introduces Store::clone_repos() to batch-clone remote repos with a parallel, non-interactive first pass and a sequential, interactive retry for auth failures.
Adds TerminalPrompt support to the Git clone flow and an is_auth_error() helper to detect auth-related clone failures.
Refactors workspace/project repo initialization to use the new batch clone API and tweaks CI detection via EnvVars::is_under_ci().

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
crates/prek/src/workspace.rs	Refactors remote repo initialization to use `Store::clone_repos()` results instead of per-repo concurrent tasks.
crates/prek/src/store.rs	Adds batched clone API with auth-failure retry sequencing and new error variant for clone failures.
crates/prek/src/git.rs	Adds `TerminalPrompt` mode support, auth-error detection, and threads prompt mode into clone/submodule operations.
crates/prek/src/cli/try_repo.rs	Updates `try-repo` to clone via `clone_repos()` instead of the removed per-repo clone API.
crates/prek/src/cli/run/run.rs	Switches CI check to `EnvVars::is_under_ci()`.
crates/prek-consts/src/env_vars.rs	Adds `LC_ALL` constant and introduces `EnvVars::is_under_ci()`.

crates/prek/src/store.rs

crates/prek/src/cli/try_repo.rs

crates/prek/src/git.rs

prek-ci-bot · 2026-03-09T12:42:13Z

📦 Cargo Bloat Comparison

Binary size change: +0.82% (24.5 MiB → 24.7 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size             Crate Name
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.7% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  77.6KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  71.4KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.6%  69.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  50.6KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  46.4KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.8KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  32.0KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  25.8KiB              prek prek::cli::try_repo::try_repo::{{closure}}
 0.1%   0.2%  24.9KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  23.1KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  22.0KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  21.5KiB              prek prek::workspace::Project::init_hooks::{{closure}}
41.1%  85.9%  10.2MiB                   And 23252 smaller methods. Use -n N to show more.
47.8% 100.0%  11.8MiB                   .text section size, the file size is 24.7MiB

Base Branch Results

 File  .text     Size             Crate Name
 1.3%   2.8% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_encrypt_avx512
 1.3%   2.8% 332.0KiB        aws_lc_sys aws_lc_0_38_0_aes_gcm_decrypt_avx512
 0.3%   0.6%  73.9KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.3%   0.6%  71.2KiB             prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.5%  65.8KiB              prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.2%   0.4%  51.0KiB annotate_snippets annotate_snippets::renderer::render::render
 0.2%   0.4%  50.6KiB              prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.4%  45.8KiB              prek prek::run::{{closure}}
 0.2%   0.3%  41.5KiB              prek prek::cli::run::run::run::{{closure}}
 0.1%   0.3%  31.8KiB             prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.1%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble_alt
 0.1%   0.2%  27.8KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_38_0_edwards25519_scalarmuldouble
 0.1%   0.2%  24.9KiB             prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.1%   0.2%  22.5KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.5KiB              prek prek::hooks::meta_hooks::MetaHooks::run::{{closure}}
 0.1%   0.2%  22.4KiB      serde_saphyr saphyr_parser_bw::scanner::Scanner<T>::fetch_more_tokens
 0.1%   0.2%  22.3KiB         [Unknown] Lp384_montjscalarmul_alt_p384_montjadd
 0.1%   0.2%  22.0KiB               std core::ptr::drop_in_place<prek::languages::<impl prek::config::Language>::install::{{closure}}>
 0.1%   0.2%  21.5KiB      clap_builder clap_builder::parser::parser::Parser::get_matches_with
41.1%  85.9%  10.1MiB                   And 22978 smaller methods. Use -n N to show more.
47.8% 100.0%  11.7MiB                   .text section size, the file size is 24.5MiB

prek-ci-bot · 2026-03-09T12:42:14Z

⚡️ Hyperfine Performance

Environment

OS: Linux 6.14.0-1017-azure
CPU: 4 cores
prek version: prek 0.3.5+4 (3dc1597 2026-03-09)
Rust version: rustc 1.94.0 (4a4ef493e 2026-03-02)
Hyperfine version: hyperfine 1.20.0

CLI Commands

Benchmarking basic commands in the main repo:

`prek --version`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base --version`	2.5 ± 0.1	2.3	2.9	1.04 ± 0.07
`prek-head --version`	2.4 ± 0.1	2.3	3.0	1.00

`prek list`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base list`	9.3 ± 0.2	9.0	9.9	1.00
`prek-head list`	9.6 ± 0.4	8.9	10.6	1.03 ± 0.05

`prek validate-config .pre-commit-config.yaml`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base validate-config .pre-commit-config.yaml`	3.4 ± 0.2	3.1	3.9	1.06 ± 0.07
`prek-head validate-config .pre-commit-config.yaml`	3.2 ± 0.1	3.0	3.5	1.00

`prek sample-config`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base sample-config`	2.7 ± 0.1	2.6	3.1	1.00 ± 0.04
`prek-head sample-config`	2.7 ± 0.1	2.6	2.8	1.00

Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

`prek run --all-files (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	156.0 ± 2.6	152.6	160.3	1.00
`prek-head run --all-files`	158.2 ± 4.6	153.6	167.9	1.01 ± 0.03

`prek run --all-files (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	157.0 ± 2.8	151.3	163.8	1.00 ± 0.02
`prek-head run --all-files`	156.9 ± 2.6	153.6	162.7	1.00

Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

`prek run --all-files (full builtin hook suite)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --all-files`	157.5 ± 2.9	152.2	164.4	1.01 ± 0.07
`prek-head run --all-files`	156.3 ± 10.5	149.0	227.1	1.00

Individual Hook Performance

Benchmarking each hook individually on the test repo:

`prek run trailing-whitespace --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run trailing-whitespace --all-files`	22.4 ± 0.9	21.6	27.0	1.00
`prek-head run trailing-whitespace --all-files`	22.5 ± 0.6	21.5	23.5	1.00 ± 0.05

`prek run end-of-file-fixer --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run end-of-file-fixer --all-files`	29.3 ± 2.2	25.3	33.4	1.03 ± 0.11
`prek-head run end-of-file-fixer --all-files`	28.5 ± 2.0	25.8	32.7	1.00

`prek run check-json --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-json --all-files`	13.7 ± 0.4	12.8	14.7	1.04 ± 0.06
`prek-head run check-json --all-files`	13.2 ± 0.7	12.2	14.9	1.00

`prek run check-yaml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-yaml --all-files`	12.4 ± 0.3	11.9	13.1	1.00
`prek-head run check-yaml --all-files`	13.0 ± 0.7	12.1	14.2	1.05 ± 0.06

`prek run check-toml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-toml --all-files`	12.6 ± 0.4	11.8	13.6	1.00
`prek-head run check-toml --all-files`	13.0 ± 0.5	12.1	13.9	1.03 ± 0.05

`prek run check-xml --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-xml --all-files`	13.1 ± 0.7	11.9	15.1	1.04 ± 0.07
`prek-head run check-xml --all-files`	12.5 ± 0.4	11.7	13.3	1.00

Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

`prek install-hooks (cold - no cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.8 ± 0.1	4.7	4.9	1.00
`prek-head install-hooks`	4.9 ± 0.1	4.8	5.1	1.02 ± 0.03

`prek install-hooks (warm - with cache)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base install-hooks`	4.9 ± 0.1	4.9	5.0	1.00
`prek-head install-hooks`	5.0 ± 0.1	4.9	5.1	1.01 ± 0.02

File Filtering/Scoping Performance

Testing different file selection modes:

`prek run (staged files only)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run`	19.6 ± 0.4	18.8	20.2	1.00
`prek-head run`	19.7 ± 0.3	19.3	20.5	1.01 ± 0.02

`prek run --files '*.json' (specific file type)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --files '*.json'`	8.4 ± 0.2	7.9	8.7	1.05 ± 0.04
`prek-head run --files '*.json'`	8.0 ± 0.2	7.6	8.3	1.00

Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

`prek run --dry-run --all-files (measures init overhead)`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run --dry-run --all-files`	13.0 ± 0.2	12.7	13.4	1.00
`prek-head run --dry-run --all-files`	13.1 ± 0.2	12.8	13.6	1.01 ± 0.03

Meta Hooks Performance

Benchmarking meta hooks separately:

`prek run check-hooks-apply --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-hooks-apply --all-files`	14.4 ± 0.6	12.8	15.1	1.09 ± 0.06
`prek-head run check-hooks-apply --all-files`	13.2 ± 0.4	12.9	14.6	1.00

`prek run check-useless-excludes --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run check-useless-excludes --all-files`	13.0 ± 0.3	12.6	13.8	1.01 ± 0.03
`prek-head run check-useless-excludes --all-files`	12.9 ± 0.1	12.7	13.3	1.00

`prek run identity --all-files`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`prek-base run identity --all-files`	11.5 ± 0.3	10.9	12.0	1.00
`prek-head run identity --all-files`	11.7 ± 0.2	11.4	12.2	1.02 ± 0.04

When a repo clone fails because authentication is required, retry that clone with GIT_TERMINAL_PROMPT=1 so Git can prompt the user for credentials. The retry flow keeps the initial clone pass non-interactive, detects auth-related failures, and then retries only those failed clones with terminal prompts enabled. Retries run sequentially so users only see one credential prompt at a time and know which repository is requesting authentication.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

crates/prek/src/git.rs

Copilot AI review requested due to automatic review settings March 9, 2026 12:25

j178 added the enhancement New feature or request label Mar 9, 2026

Copilot started reviewing on behalf of j178 March 9, 2026 12:26 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

crates/prek/src/store.rs Show resolved Hide resolved

crates/prek/src/cli/try_repo.rs Outdated Show resolved Hide resolved

crates/prek/src/git.rs Outdated Show resolved Hide resolved

crates/prek/src/git.rs Show resolved Hide resolved

j178 force-pushed the git-clone branch from 7a6d28c to d0bad20 Compare March 9, 2026 14:43

j178 added 2 commits March 9, 2026 22:45

Docs

bfca997

Minor

ee8d563

Copilot AI review requested due to automatic review settings March 9, 2026 14:48

Copilot started reviewing on behalf of j178 March 9, 2026 14:48 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

crates/prek/src/git.rs Show resolved Hide resolved

crates/prek/src/git.rs Show resolved Hide resolved

j178 merged commit 6d07a0e into master Mar 9, 2026
55 checks passed

j178 deleted the git-clone branch March 9, 2026 15:03

BrewTestBot mentioned this pull request Mar 16, 2026

prek 0.3.6 Homebrew/homebrew-core#272532

Merged

Conversation

j178 commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prek-ci-bot bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

prek-ci-bot bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Hyperfine Performance

prek --version

prek list

prek validate-config .pre-commit-config.yaml

prek sample-config

prek run --all-files (cold - no cache)

prek run --all-files (warm - with cache)

prek run --all-files (full builtin hook suite)

prek run trailing-whitespace --all-files

prek run end-of-file-fixer --all-files

prek run check-json --all-files

prek run check-yaml --all-files

prek run check-toml --all-files

prek run check-xml --all-files

prek install-hooks (cold - no cache)

prek install-hooks (warm - with cache)

prek run (staged files only)

prek run --files '*.json' (specific file type)

prek run --dry-run --all-files (measures init overhead)

prek run check-hooks-apply --all-files

prek run check-useless-excludes --all-files

prek run identity --all-files

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

j178 commented Mar 9, 2026 •

edited

Loading

codecov bot commented Mar 9, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 9, 2026 •

edited

Loading

prek-ci-bot bot commented Mar 9, 2026 •

edited

Loading

`prek --version`

`prek list`

`prek validate-config .pre-commit-config.yaml`

`prek sample-config`

`prek run --all-files (cold - no cache)`

`prek run --all-files (warm - with cache)`

`prek run --all-files (full builtin hook suite)`

`prek run trailing-whitespace --all-files`

`prek run end-of-file-fixer --all-files`

`prek run check-json --all-files`

`prek run check-yaml --all-files`

`prek run check-toml --all-files`

`prek run check-xml --all-files`

`prek install-hooks (cold - no cache)`

`prek install-hooks (warm - with cache)`

`prek run (staged files only)`

`prek run --files '*.json' (specific file type)`

`prek run --dry-run --all-files (measures init overhead)`

`prek run check-hooks-apply --all-files`

`prek run check-useless-excludes --all-files`

`prek run identity --all-files`