Skip to content

Use module and method descriptor types declared in the types module#14055

Merged
Carreau merged 1 commit intoipython:mainfrom
ccordoba12:issue-14041
Jun 2, 2023
Merged

Use module and method descriptor types declared in the types module#14055
Carreau merged 1 commit intoipython:mainfrom
ccordoba12:issue-14041

Conversation

@ccordoba12
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 commented Apr 28, 2023

Fixes #14041.

@ccordoba12 ccordoba12 requested a review from krassowski April 28, 2023 16:49
@ccordoba12 ccordoba12 self-assigned this Apr 28, 2023
krassowski
krassowski approved these changes Apr 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ccordoba12!

@Carreau Carreau added this to the 8.14 milestone Jun 2, 2023
@Carreau Carreau merged commit 3a567f0 into ipython:main Jun 2, 2023
@Carreau
Copy link
Copy Markdown
Member

Carreau commented Jun 2, 2023

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@ccordoba12 ccordoba12

Labels

tab-completion

Projects

None yet

Milestone

8.14

Development

Successfully merging this pull request may close these issues.

Update type(...) to import the Type from it's canonical location

3 participants

@ccordoba12 @Carreau @krassowski