Let get_parent decide the channel to get parent header#1128
Merged
minrk merged 2 commits intoipython:mainfrom Jun 27, 2023
dby-tmwctw:fixing-get-parent
Merged
Let get_parent decide the channel to get parent header#1128minrk merged 2 commits intoipython:mainfrom dby-tmwctw:fixing-get-parent
minrk merged 2 commits intoipython:mainfrom
dby-tmwctw:fixing-get-parent
Conversation
minrk
approved these changes
Jun 26, 2023
Member
|
Thanks! |
Contributor
Author
|
Hi @minrk Thanks a lot for the approval! It's my first time contributing so may I know who to ask for merging this PR? |
Member
|
@dby-tmwctw I have merged it. I was waiting for CI to finish. |
Contributor
|
I'm on vacation this week, I can cut a release next week. |
Member
While this PR complies with the spec, I would like to emphasize that according to the Jupyter kernel protocol specification, comm messages are only to be sent on the Shell channel and not the Control channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous PR we addressed the problem where iopub
commmessages generated by control channel have the wrong parent header from shell channel due to hard code. This PR move the logic toget_parent(following discussions here from @jasongrout and @minrk ) so we remove the hard-coding problem not only for thecommmessages, but for other iopub messages as well.