feat: re-export types from @helia/interface#232
Merged
achingbrain merged 1 commit intomainfrom Aug 16, 2023
Merged
Conversation
`@helia/interface` lets us depend on the shape of a `Helia` without having to depend on `helia` directly which is useful when you are writing something lightweight and don't want to pull in libp2p etc during an `npm i`, but in some cases we will have a dep on `helia` so re-export the types from `@helia/interface` to not force people to have a dependency on both.
SgtPooki
approved these changes
Aug 14, 2023
whizzzkid
approved these changes
Aug 15, 2023
Contributor
whizzzkid
left a comment
There was a problem hiding this comment.
I thought this was intentionally left out to segregate the responsibilities. This makes sense!
Member
Author
It was, but from a practical perspective it's a pain to use. By shipping |
This was referenced Jan 8, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@helia/interfacelets us depend on the shape of aHeliawithout having to depend onheliadirectly which is useful when you are writing something lightweight and don't want to pull in libp2p etc during annpm i, but in some cases we will have a dep onheliaso re-export the types from@helia/interfaceto not force people to have a dependency on both.