fix: Update required node version to node 18 and npm 8#1184
Merged
achingbrain merged 2 commits intomasterfrom May 9, 2023
Merged
fix: Update required node version to node 18 and npm 8#1184achingbrain merged 2 commits intomasterfrom
achingbrain merged 2 commits intomasterfrom
Conversation
achingbrain
requested changes
Feb 7, 2023
achingbrain
approved these changes
May 9, 2023
Member
|
This may need revising in future to correct the minor/patch version. |
github-actions Bot
pushed a commit
that referenced
this pull request
May 9, 2023
## [39.0.6](v39.0.5...v39.0.6) (2023-05-09) ### Bug Fixes * Update required node version to node 18 and npm 8 ([#1184](#1184)) ([b7ef86c](b7ef86c))
|
🎉 This PR is included in version 39.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
achingbrain
added a commit
that referenced
this pull request
May 17, 2023
The engines field causes warnings on npm but errors on yarn when the required node version is not met. Not all of our modules require LTS node and they are used by projects outside of libp2p/helia/etc. This change removes the automatic addition of an engines field to a project's `package.json` while running the `check-project` command, instead projects that do require a certain node version are free to define it and deal with the breakage that subsequently occurs. Partial revert of: #1184 Refs: #1276
achingbrain
added a commit
that referenced
this pull request
May 19, 2023
The engines field causes warnings on npm but errors on yarn when the required node version is not met. Not all of our modules require LTS node and they are used by projects outside of libp2p/helia/etc. This change removes the automatic addition of an engines field to a project's `package.json` while running the `check-project` command, instead projects that do require a certain node version are free to define it and deal with the breakage that subsequently occurs. Partial revert of: #1184 Refs: #1276
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on: ipfs/helia#30