fix(plugin): normalize dependency path#459
Merged
christian-bromann merged 5 commits intomainfrom Jan 19, 2024
Merged
Conversation
dda2490 to
b818ef1
Compare
rwaskiewicz
reviewed
Jan 17, 2024
12 tasks
rwaskiewicz
approved these changes
Jan 18, 2024
Member
rwaskiewicz
left a comment
There was a problem hiding this comment.
One non-blocking question. Otherwise tested locally on Windows 11 - works as expected!
Recording.2024-01-18.160930.mp4
Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
tanner-reits
approved these changes
Jan 19, 2024
3 tasks
jcfranco
referenced
this pull request
in Esri/calcite-design-system
Apr 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stencil/sass](https://stenciljs.com/) ([source](https://togithub.com/ionic-team/stencil-sass)) | [`3.0.8` -> `3.0.11`](https://renovatebot.com/diffs/npm/@stencil%2fsass/3.0.8/3.0.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ionic-team/stencil-sass (@​stencil/sass)</summary> ### [`v3.0.11`](https://togithub.com/ionic-team/stencil-sass/releases/tag/v3.0.11) [Compare Source](https://togithub.com/ionic-team/stencil-sass/compare/v3.0.10...v3.0.11) ### Dependency Updates - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.12.6 ([#​498](https://togithub.com/ionic-team/stencil-sass/issues/498)) [`cb6c016`](https://togithub.com/ionic-team/stencil-sass/commit/cb6c016) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.12.5 ([#​495](https://togithub.com/ionic-team/stencil-sass/issues/495)) [`0a72c0a`](https://togithub.com/ionic-team/stencil-sass/commit/0a72c0a) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.12.4 ([#​491](https://togithub.com/ionic-team/stencil-sass/issues/491)) [`7f06fb1`](https://togithub.com/ionic-team/stencil-sass/commit/7f06fb1) - chore(deps): update actions/download-artifact action to v4.1.4 ([#​494](https://togithub.com/ionic-team/stencil-sass/issues/494)) [`ea7d4db`](https://togithub.com/ionic-team/stencil-sass/commit/ea7d4db) - chore(deps): update actions/download-artifact action to v4.1.3 ([#​490](https://togithub.com/ionic-team/stencil-sass/issues/490)) [`2382d2e`](https://togithub.com/ionic-team/stencil-sass/commit/2382d2e) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.13.0 ([#​502](https://togithub.com/ionic-team/stencil-sass/issues/502)) [`f55a21d`](https://togithub.com/ionic-team/stencil-sass/commit/f55a21d) - chore(deps): update dependency np to v10.0.1 ([#​500](https://togithub.com/ionic-team/stencil-sass/issues/500)) [`2ec062f`](https://togithub.com/ionic-team/stencil-sass/commit/2ec062f) - chore(deps): update dependency np to v10 ([#​492](https://togithub.com/ionic-team/stencil-sass/issues/492)) [`b3e9539`](https://togithub.com/ionic-team/stencil-sass/commit/b3e9539) - chore(deps): update dependency npm to v10.5.0 ([#​493](https://togithub.com/ionic-team/stencil-sass/issues/493)) [`0c69911`](https://togithub.com/ionic-team/stencil-sass/commit/0c69911) - chore(deps): update dependency rollup to v4.13.0 ([#​499](https://togithub.com/ionic-team/stencil-sass/issues/499)) [`7ea9056`](https://togithub.com/ionic-team/stencil-sass/commit/7ea9056) - chore(deps): update dependency rollup to v4.12.1 ([#​496](https://togithub.com/ionic-team/stencil-sass/issues/496)) [`375ae23`](https://togithub.com/ionic-team/stencil-sass/commit/375ae23) - chore(deps): update dependency terser to v5.29.2 ([#​501](https://togithub.com/ionic-team/stencil-sass/issues/501)) [`cd2c645`](https://togithub.com/ionic-team/stencil-sass/commit/cd2c645) - chore(deps): update dependency terser to v5.29.1 ([#​497](https://togithub.com/ionic-team/stencil-sass/issues/497)) [`cab9c66`](https://togithub.com/ionic-team/stencil-sass/commit/cab9c66) - chore(deps): update dependency terser to v5.28.1 ([#​489](https://togithub.com/ionic-team/stencil-sass/issues/489)) [`4621f83`](https://togithub.com/ionic-team/stencil-sass/commit/4621f83) ### [`v3.0.10`](https://togithub.com/ionic-team/stencil-sass/releases/tag/v3.0.10) [Compare Source](https://togithub.com/ionic-team/stencil-sass/compare/v3.0.9...v3.0.10) Dependency Updates - chore(deps): update actions/checkout action to v4 ([#​471](https://togithub.com/ionic-team/stencil-sass/issues/471)) [`62497d1`](https://togithub.com/ionic-team/stencil-sass/commit/62497d1) - chore(deps): update actions/download-artifact action to v4.1.2 ([#​474](https://togithub.com/ionic-team/stencil-sass/issues/474)) [`fe6bbad`](https://togithub.com/ionic-team/stencil-sass/commit/fe6bbad) - chore(deps): update actions/setup-node action to v4.0.2 ([#​477](https://togithub.com/ionic-team/stencil-sass/issues/477)) [`074e402`](https://togithub.com/ionic-team/stencil-sass/commit/074e402) - chore(deps): update actions/upload-artifact action to v4.3.1 ([#​475](https://togithub.com/ionic-team/stencil-sass/issues/475)) [`0e1d9b6`](https://togithub.com/ionic-team/stencil-sass/commit/0e1d9b6) - chore(deps): update actions/upload-artifact action to v4.3.0 ([#​470](https://togithub.com/ionic-team/stencil-sass/issues/470)) [`e108588`](https://togithub.com/ionic-team/stencil-sass/commit/e108588) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.12.3 ([#​488](https://togithub.com/ionic-team/stencil-sass/issues/488)) [`b6ed3bb`](https://togithub.com/ionic-team/stencil-sass/commit/b6ed3bb) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.12.2 ([#​479](https://togithub.com/ionic-team/stencil-sass/issues/479)) [`4487f18`](https://togithub.com/ionic-team/stencil-sass/commit/4487f18) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.12.1 ([#​476](https://togithub.com/ionic-team/stencil-sass/issues/476)) [`a2cc3b2`](https://togithub.com/ionic-team/stencil-sass/commit/a2cc3b2) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.12.0 ([#​472](https://togithub.com/ionic-team/stencil-sass/issues/472)) [`739589c`](https://togithub.com/ionic-team/stencil-sass/commit/739589c) - chore(deps): update node.js to v20.11.1 ([#​480](https://togithub.com/ionic-team/stencil-sass/issues/480)) [`c2c5838`](https://togithub.com/ionic-team/stencil-sass/commit/c2c5838) - chore(deps): update dependency prettier to v3.2.5 ([#​473](https://togithub.com/ionic-team/stencil-sass/issues/473)) [`36939f5`](https://togithub.com/ionic-team/stencil-sass/commit/36939f5) - chore(deps): update dependency rollup to v4.12.0 ([#​486](https://togithub.com/ionic-team/stencil-sass/issues/486)) [`4d9ed5d`](https://togithub.com/ionic-team/stencil-sass/commit/4d9ed5d) - chore(deps): update dependency rollup to v4.11.0 ([#​485](https://togithub.com/ionic-team/stencil-sass/issues/485)) [`f3a8c23`](https://togithub.com/ionic-team/stencil-sass/commit/f3a8c23) - chore(deps): update dependency rollup to v4.10.0 ([#​478](https://togithub.com/ionic-team/stencil-sass/issues/478)) [`4e6011f`](https://togithub.com/ionic-team/stencil-sass/commit/4e6011f) - chore(deps): update dependency terser to v5.27.2 ([#​487](https://togithub.com/ionic-team/stencil-sass/issues/487)) [`10089dd`](https://togithub.com/ionic-team/stencil-sass/commit/10089dd) - chore(deps): update dependency terser to v5.27.1 ([#​484](https://togithub.com/ionic-team/stencil-sass/issues/484)) [`c03fd37`](https://togithub.com/ionic-team/stencil-sass/commit/c03fd37) Misc - chore(ci): add automated dev releases ([#​467](https://togithub.com/ionic-team/stencil-sass/issues/467)) [`99008b4`](https://togithub.com/ionic-team/stencil-sass/commit/99008b4) ### [`v3.0.9`](https://togithub.com/ionic-team/stencil-sass/releases/tag/v3.0.9) [Compare Source](https://togithub.com/ionic-team/stencil-sass/compare/v3.0.8...v3.0.9) #### What's Changed ##### Bug Fixes - fix(plugin): normalize dependency path by [@​christian-bromann](https://togithub.com/christian-bromann) in [https://github.com/ionic-team/stencil-sass/pull/459](https://togithub.com/ionic-team/stencil-sass/pull/459) ##### Dependency Updates - chore(deps): update dependency np to v9.2.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/451](https://togithub.com/ionic-team/stencil-sass/pull/451) - chore(deps): update actions/setup-node action to v4.0.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/454](https://togithub.com/ionic-team/stencil-sass/pull/454) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.9.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/455](https://togithub.com/ionic-team/stencil-sass/pull/455) - chore(deps): update dependency prettier to v3.1.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/452](https://togithub.com/ionic-team/stencil-sass/pull/452) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.9.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/456](https://togithub.com/ionic-team/stencil-sass/pull/456) - chore(deps): update dependency npm to v10.3.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/457](https://togithub.com/ionic-team/stencil-sass/pull/457) - chore(deps): update dependency prettier to v3.2.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/458](https://togithub.com/ionic-team/stencil-sass/pull/458) - chore(deps): update node.js to v20.11.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/443](https://togithub.com/ionic-team/stencil-sass/pull/443) - chore(deps): update dependency rollup to v4.9.5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/442](https://togithub.com/ionic-team/stencil-sass/pull/442) - chore(deps): update dependency prettier to v3.2.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/460](https://togithub.com/ionic-team/stencil-sass/pull/460) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.10.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/462](https://togithub.com/ionic-team/stencil-sass/pull/462) - chore(deps): update dependency terser to v5.27.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/464](https://togithub.com/ionic-team/stencil-sass/pull/464) - chore(deps): update dependency prettier to v3.2.4 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/463](https://togithub.com/ionic-team/stencil-sass/pull/463) - chore(build): improve build process by [@​christian-bromann](https://togithub.com/christian-bromann) in [https://github.com/ionic-team/stencil-sass/pull/461](https://togithub.com/ionic-team/stencil-sass/pull/461) - chore(deps): update dependency rollup to v4.9.6 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/465](https://togithub.com/ionic-team/stencil-sass/pull/465) - chore(deps): update dependency [@​stencil/core](https://togithub.com/stencil/core) to v4.11.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/466](https://togithub.com/ionic-team/stencil-sass/pull/466) - chore(deps): update dependency npm to v10.4.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/ionic-team/stencil-sass/pull/468](https://togithub.com/ionic-team/stencil-sass/pull/468) #### New Contributors - [@​christian-bromann](https://togithub.com/christian-bromann) made their first contribution in [https://github.com/ionic-team/stencil-sass/pull/459](https://togithub.com/ionic-team/stencil-sass/pull/459) **Full Changelog**: stenciljs/sass@v3.0.8...v3.0.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Sass compiler dependencies aren't recognised given Windows path.
GitHub Issue Number: stenciljs/core#4130
What is the new behavior?
When changing dependent sass files, the compiler now correctly reloads the component with updated styles.
Does this introduce a breaking change?
Testing
I used a virtual machine and updated the compiled code directly using the reproducible example provided in stenciljs/core#4130. Any suggestions how I can provide something better given this bug is related to Windows.
Other information
n/a