fix(utils): only run plugin for sass files#361
Merged
rwaskiewicz merged 1 commit intomainfrom Jul 13, 2023
Merged
Conversation
tanner-reits
approved these changes
Jul 5, 2023
alicewriteswrongs
approved these changes
Jul 5, 2023
this commit updates the utility method for checking whether the plugin should run on a file, `usePlugin` to return `false` for files that do not end in `.sass`/`.scss`.
bf2231d to
546858b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
While I do not believe this occurs in practice, it is theoretically possible to try to run the plugin if a non-string filename is somehow provided to the plugin's
transformfunctionGitHub Issue Number: N/A
What is the new behavior?
this commit updates the utility method for checking whether the plugin should run on a file,
usePluginto returnfalsefor files that do not end in.sass/.scss.Does this introduce a breaking change?
Testing
Updated unit tests.
The Ionic Framework never actually appears to hit the
returnstatement I updated here, and should not be affected by this changeOther information