chore(package): add engines to package.json#337
Merged
rwaskiewicz merged 1 commit intomainfrom Jun 21, 2023
Merged
Conversation
tanner-reits
approved these changes
Jun 12, 2023
sean-perkins
approved these changes
Jun 20, 2023
this commit adds an engines field to the package to explicitly state what versions of node/npm that are currently supported. the current version of the package supports stencil v2 and up - stencil v2 supported node 12+, which is the justification for such a low version of node/npm in these fields
aae8e17 to
f1bcad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
We don't have
enginesspecified, which is blocking #324GitHub Issue Number: N/A
What is the new behavior?
this commit adds an engines field to the package to explicitly state what versions of node/npm that are currently supported. the current version of the package supports stencil v2 and up - stencil v2 supported node 12+, which is the justification for such a low version of node/npm in these fields
Does this introduce a breaking change?
Testing
N/A
Other information