refactor(diagnostics): replace substr calls w substring#226
Merged
rwaskiewicz merged 1 commit intomainfrom Mar 13, 2023
Merged
Conversation
tanner-reits
approved these changes
Feb 13, 2023
2f22174 to
defb8fb
Compare
Member
Author
|
@alicewriteswrongs can you do me a favor and take a look at this before the end of the sprint? I'd like to ship this in the next release of the library |
alicewriteswrongs
approved these changes
Mar 13, 2023
Contributor
alicewriteswrongs
left a comment
There was a problem hiding this comment.
sorry I missed this - all looks good 
this commit updates diagnostic generation to use `substring` instead of the deprecated `substr` function. the original calls to `substr` used only a single parameter, the start index of the substring to grab. this allowed for a simple swap of the two calls
b1a3a18 to
65a89d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
This package uses a deprecated
substrfunctionGitHub Issue Number: N/A
What is the new behavior?
this commit updates diagnostic generation to use
substringinstead ofthe deprecated
substrfunction. the original calls tosubstrusedonly a single parameter, the start index of the substring to grab. this
allowed for a simple swap of the two calls
Does this introduce a breaking change?
Testing
I didn't test this 😬
Other information
Dependent on #225