Skip to content

fix(android): invalid http range seeking#8369

Merged
OS-pedrogustavobilro merged 3 commits intoionic-team:mainfrom
Maroon-Rides:fix/range-seek
Mar 2, 2026
Merged

fix(android): invalid http range seeking#8369
OS-pedrogustavobilro merged 3 commits intoionic-team:mainfrom
Maroon-Rides:fix/range-seek

Conversation

@bwees
Copy link
Copy Markdown
Contributor

@bwees bwees commented Mar 1, 2026

Fixes a regression introduced in #8357.

Closes #8367.

@OS-pedrogustavobilro OS-pedrogustavobilro self-assigned this Mar 2, 2026
Copy link
Copy Markdown
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bwees thanks for the PR!

Indeed, this fixes a regression.

It seems Chrome WebView already calls skip under the hood (checked debugging the native code), so the skip call added in the previous PR shouldn't be there.

However, CI is failing because of lint. Since you did not check to allow maintainers to edit, please run npm run fmt to fix lint issue, and sync with upstream (other PRs have been merged since). Afterwards, we can merge this PR.

@bwees
Copy link
Copy Markdown
Contributor Author

bwees commented Mar 2, 2026

Hey there!

Sorry about that. I have ran the lint and synced the branch as requested. I cannot enable access to maintainers since the fork is owned by a GitHub organization 😔.

Let me know if there need to be any further updates.

Copy link
Copy Markdown
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now @bwees, thanks!

@OS-pedrogustavobilro OS-pedrogustavobilro merged commit 3109d22 into ionic-team:main Mar 2, 2026
6 checks passed
OS-pedrogustavobilro pushed a commit that referenced this pull request Mar 3, 2026
Closes #8367

Fixes regression introduced by #8357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: PR #8357 Regression

2 participants