Skip to content

refactor(spring): move auto-configuration registration to AutoConfiguration.imports as is recommended from Spring Boot 2.7#470

Merged
bednar merged 2 commits intomasterfrom
refactor-spring-autoconfiguration
Nov 28, 2022
Merged

refactor(spring): move auto-configuration registration to AutoConfiguration.imports as is recommended from Spring Boot 2.7#470
bednar merged 2 commits intomasterfrom
refactor-spring-autoconfiguration

Conversation

@bednar
Copy link
Contributor

@bednar bednar commented Nov 25, 2022 •
edited
Loading

Closes #468

Use META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports for registration of auto-configuration.

Proposed Changes

Auto-configuration Registration

If you have created your own auto-configurations, you should move the registration from spring.factories 
under the org.springframework.boot.autoconfigure.EnableAutoConfiguration key to a new file named 
META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports. Rather than a single
comma-separate list, each line contains the fully qualified name of an auto-configuration class. 
See [the included auto-configurations](https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-autoconfigure/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports) 
for an example.

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#auto-configuration-registration

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar
refactor(spring): move autoconfiguration registration `AutoConfigurat…
6fdbf2d 
…ion.imports` as is recommended from Spring Boot 2.7
@bednar bednar changed the title refactor(spring): move auto-configuration registration AutoConfiguration.imports as is recommended from Spring Boot 2.7 refactor(spring): move auto-configuration registration to AutoConfiguration.imports as is recommended from Spring Boot 2.7 Nov 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Base: 88.39% // Head: 88.39% // No change to project coverage 👍

Coverage data is based on head (6cb5c39) compared to base (cec6457).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #470   +/-   ##
=========================================
  Coverage     88.39%   88.39%           
  Complexity      779      779           
=========================================
  Files           172      172           
  Lines          7008     7008           
  Branches        378      378           
=========================================
  Hits           6195     6195           
  Misses          693      693           
  Partials        120      120

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar marked this pull request as ready for review November 25, 2022 09:37
@bednar bednar merged commit 1747d29 into master Nov 28, 2022
@bednar bednar deleted the refactor-spring-autoconfiguration branch November 28, 2022 21:54
@bednar bednar added this to the 6.8.0 milestone Nov 28, 2022
@bednar bednar mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlastahajek vlastahajek Awaiting requested review from vlastahajek

1 more reviewer

@powersj powersj powersj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.8.0

Development

Successfully merging this pull request may close these issues.

Replacing spring.factories auto-configuration setup with new file as stated per Spring Boot 2.7 release notes

3 participants

@bednar @codecov-commenter @powersj