Skip to content

Support validation of Cosign OCI statements with type https://in-toto.io/Statement/v0.1#464

Merged
marcelamelara merged 1 commit intoin-toto:mainfrom
alenon:feature/support-cosign-oci-statement
Aug 27, 2025
Merged

Support validation of Cosign OCI statements with type https://in-toto.io/Statement/v0.1#464
marcelamelara merged 1 commit intoin-toto:mainfrom
alenon:feature/support-cosign-oci-statement

Conversation

@alenon
Copy link
Copy Markdown
Contributor

@alenon alenon commented May 19, 2025

Support validation of Cosign OCI statements with type https://in-toto.io/Statement/v0.1

This change updates the method to allow statements with type v0.1 in addition to v1. This ensures compatibility with Cosign OCI signatures.

Fixes #461

@alenon alenon requested a review from a team as a code owner May 19, 2025 11:37
Copy link
Copy Markdown
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this @alenon , apologies for the very long delay. I think these changes will be helpful for backwards compatibility, but don't want to lose the specificity of checking the supported versions.

Comment thread go/v1/statement.go Outdated
@marcelamelara
Copy link
Copy Markdown
Contributor

@in-toto/attestation-maintainers can we please get a second review here?

@alenon alenon force-pushed the feature/support-cosign-oci-statement branch from a0b44fb to c4688e3 Compare August 4, 2025 19:33
@alenon alenon requested a review from marcelamelara August 4, 2025 19:38
Copy link
Copy Markdown
Contributor

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your much-needed PR! Left some minor comments...

Comment thread go/v1/statement.go Outdated
Comment thread go/v1/statement.go Outdated
@alenon alenon force-pushed the feature/support-cosign-oci-statement branch from 8727b89 to 55da453 Compare August 26, 2025 18:35
Comment thread go/v1/statement.go Outdated
@alenon alenon force-pushed the feature/support-cosign-oci-statement branch 2 times, most recently from 0bda362 to 79d1d7c Compare August 26, 2025 19:08
Copy link
Copy Markdown
Contributor

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment thread go/v1/statement.go Outdated
….io/Statement/v0.1

This change updates the  method to allow statements with type v0.1 in addition to v1. This ensures compatibility with Cosign OCI signatures.

Fixes in-toto#461

Signed-off-by: Yevdo Abramov <5107130+alenon@users.noreply.github.com>
@alenon alenon force-pushed the feature/support-cosign-oci-statement branch from 51265b0 to 6264e54 Compare August 27, 2025 04:37
Copy link
Copy Markdown
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these updates @alenon ! Looks great now.

@marcelamelara marcelamelara merged commit d8c9aa2 into in-toto:main Aug 27, 2025
2 of 3 checks passed
@alenon alenon deleted the feature/support-cosign-oci-statement branch August 28, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Validation of Cosign OCI Statements with Type https://in-toto.io/Statement/v0.1

3 participants