Ensure the Envelope spec meets ITE-5#431
Merged
marcelamelara merged 7 commits intoin-toto:mainfrom Mar 11, 2026
Merged
Conversation
trishankatdatadog
approved these changes
Jan 17, 2025
adityasaky
reviewed
Jan 20, 2025
abe3cb3 to
4defcd2
Compare
TomHennen
approved these changes
May 20, 2025
Contributor
TomHennen
left a comment
There was a problem hiding this comment.
Sorry I missed this request for review :(
f78f4a2 to
4c0ae5e
Compare
adityasaky
approved these changes
May 21, 2025
trishankatdatadog
previously requested changes
May 22, 2025
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
21e4c82 to
a3504e8
Compare
Contributor
Author
|
@trishankkarthik Can you please re-approve? |
Contributor
Author
|
@puerco @SantiagoTorres since this is a spec change, I think it'd be good to get one more approval on this PR. Can either of you PTAL? |
marcelamelara
commented
Mar 11, 2026
SAY-5
added a commit
to SAY-5/attestation
that referenced
this pull request
May 2, 2026
* Ensure the Envelope spec meets ITE-5 * Add payloadType signature requirement * Remove some unnecessary slashes * Specify payloadType for any envelope type * Add some more context to signatures and keyid fields * Fix signatures field name * Update spec/v1/envelope.md --------- Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between some past changes and missing content, the Envelope spec isn't fully compliant with ITE-5. This PR fixes that.
Fixes #21