Merged
Conversation
|
I'm just lurking here, but want to say this looks great. The "After" screenshot does look more readable, without significantly altering the look-and-feel of things. |
Member
|
I'm on holiday right now, but thanks a lot for the effort! For what it's worth, there is a dark mode available too if you want to look at it too (if not no problem 👌) |
jdeniau
reviewed
Aug 20, 2025
| --header-content-padding: 12px; | ||
|
|
||
| --link-color: #4183c4; | ||
| --link-color: #355B7E; |
Member
There was a problem hiding this comment.
This make contrast 7:1, this is nice for accessibility, but it make the link less visible as a link (it's nearly the same color as the text).
I changed to a 4.5:1 so it's still AA, but more understandable that it's a link.
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before
After