You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The diff did change as the import order did change.
It SHOULD be safe though to push that on main as the import order should not impact end user.
I ran copilot on that one to see if there is a side effect on the src dir, and here is the result:
After searching and scanning the entire src directory for side effects, here are the findings:
No files in src directly reference or mutate global objects like globalThis, window, self, or global.
No files in src use setTimeout, setInterval, eval, or similar APIs that would cause top-level side effects.
The only use of Object.defineProperty is in Record.js and Hash.js, but these are used to define properties on objects or prototypes, not on global objects. This is a standard, side-effect-free pattern unless the prototype is a global object (which it is not in this context).
No files in src use require or import() in a way that would cause dynamic side effects.
The only console usage in Record.js is for warnings, which is not a side effect that would impact library consumers.
No evidence of IIFEs, singletons, or top-level code that mutates global state.
Conclusion:
The code in the src directory does not contain side effects that would be affected by the order of import statements in your entry file. Sorting imports in Immutable.js is safe and will not impact end users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may help reviewing #2105