Add explicit serde feature#436
Merged
Merged
Conversation
iliekturtles
left a comment
Owner
There was a problem hiding this comment.
Thanks for taking this on. One minor documentation change requested below.
This revision adds an explicit Cargo feature named serde. This feature is analogous to the old use_serde feature, but uses features of Cargo's new feature resolver to automatically enable serde features for num-* crates as appropriate. The use_serde feature is now a (deprecated) alias for this new serde feature.
Contributor
Author
|
Added comments to Cargo.toml and README.md and squashed into the prior commit. |
Owner
|
Merged! Thanks again for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision adds an explicit Cargo feature named
serde. This feature is almost identical to the olduse_serdefeature, but uses features of Cargo's new feature resolver to automatically enableserdefeatures fornum-*crates as appropriate. Theuse_serdefeature is now a (deprecated) alias for this newserdefeature.Very few changes were required, since
uomwas already using the (then-implicit)serdefeature to begin with. I was unable to find an elegant way to warn users specifyinguse_serdeto switch to the new feature.This closes #216.