Skip to content

chore: add buildtools edition#69

Merged
ilammy merged 1 commit into
ilammy:masterfrom
qkdreyer:patch-1
Jan 1, 2024
Merged

chore: add buildtools edition#69
ilammy merged 1 commit into
ilammy:masterfrom
qkdreyer:patch-1

Conversation

@qkdreyer

Copy link
Copy Markdown
Contributor

No description provided.

@qkdreyer qkdreyer changed the base branch from master to release/v1 October 11, 2023 09:53
@pzhlkj6612

Copy link
Copy Markdown
Contributor

Hi! Your Git history looks not so good (This branch is 19 commits ahead, 1 commit behind ilammy:master). Maybe a git rebase a742a854f54111d83b78e97091b5d85ccdaa3e89 command can solve it.

@qkdreyer qkdreyer changed the base branch from release/v1 to master October 12, 2023 13:20
@qkdreyer

Copy link
Copy Markdown
Contributor Author

@pzhlkj6612 done!

@pzhlkj6612

Copy link
Copy Markdown
Contributor

Hi @qkdreyer , I have a question: how do you test your change? In GitHub's runner, this action is able to find the Enterprise edition of Visual Studio and will not try other editions. Are you using a self-hosted runner?

@qkdreyer

Copy link
Copy Markdown
Contributor Author

yeah using a self hosted runner and installed using chocolatey : https://community.chocolatey.org/packages/visualstudio2019buildtools

@qkdreyer

Copy link
Copy Markdown
Contributor Author

@pzhlkj6612 pzhlkj6612 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@qkdreyer

Copy link
Copy Markdown
Contributor Author

@ilammy

@qkdreyer

Copy link
Copy Markdown
Contributor Author

can we merge that?

@ilammy

ilammy commented Jan 1, 2024

Copy link
Copy Markdown
Owner

Sorry for taking so long 🙇

@ilammy ilammy merged commit 6357fb6 into ilammy:master Jan 1, 2024
@qkdreyer qkdreyer deleted the patch-1 branch April 25, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants