Skip to content

chore(tls): Small refactoring#1487

Merged
LucioFranco merged 2 commits intohyperium:masterfrom
tottoto:refactor-transport-tls
Sep 1, 2023
Merged

chore(tls): Small refactoring#1487
LucioFranco merged 2 commits intohyperium:masterfrom
tottoto:refactor-transport-tls

Conversation

@tottoto
Copy link
Copy Markdown
Collaborator

@tottoto tottoto commented Aug 29, 2023

Motivation

Small refactorings of tonic's tls config.

Solution

  • Removes rustls crate from dependencies as it is not used.
  • Updates to rustls-native-certs 0.6.3 from 0.6.1 and use its AsRef<[u8]> for Certificate.
  • Uses AsRef<u8> for tonic's Certificate struct instead of slice syntax.

@tottoto tottoto force-pushed the refactor-transport-tls branch from fa51559 to 77a96b6 Compare August 29, 2023 16:15
@tottoto tottoto changed the title chore(tls): Simplify implementation chore(tls): Small refactoring Aug 29, 2023
djc
djc approved these changes Aug 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by review: LGTM!

@LucioFranco LucioFranco added this pull request to the merge queue Sep 1, 2023
Merged via the queue into hyperium:master with commit e7744ec Sep 1, 2023
@tottoto tottoto deleted the refactor-transport-tls branch September 1, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@djc djc djc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tottoto @djc @LucioFranco