Skip to content

chore(transport) Re-export axum::Router as AxumRouter#1483

Merged
LucioFranco merged 4 commits intohyperium:masterfrom
tottoto:re-export-axum-router
Sep 1, 2023
Merged

chore(transport) Re-export axum::Router as AxumRouter#1483
LucioFranco merged 4 commits intohyperium:masterfrom
tottoto:re-export-axum-router

Conversation

@tottoto
Copy link
Copy Markdown
Collaborator

@tottoto tottoto commented Aug 28, 2023

Resolves #1479.

@tottoto
Copy link
Copy Markdown
Collaborator Author

tottoto commented Aug 28, 2023

The failed codegen ci would be fixed in #1484.

@tottoto tottoto force-pushed the re-export-axum-router branch from a83269e to eb1aa0e Compare August 29, 2023 16:20
@tottoto tottoto changed the title chore(tonic) Re-export axum::Router as AxumRouter chore(transport) Re-export axum::Router as AxumRouter Aug 29, 2023
@tottoto
Copy link
Copy Markdown
Collaborator Author

tottoto commented Aug 29, 2023

As I found that axum::Router returned by tonic's Router::into_router uses axum::body::BoxBody, it might be useful to re-export axum's BoxBody as well.

@tottoto tottoto force-pushed the re-export-axum-router branch from d3ed9a0 to fa5d8b3 Compare August 29, 2023 16:27
@LucioFranco LucioFranco added this pull request to the merge queue Sep 1, 2023
Merged via the queue into hyperium:master with commit 6db46e0 Sep 1, 2023
@tottoto tottoto deleted the re-export-axum-router branch September 1, 2023 17:17
Koh0920 added a commit to ato-run/nacelle that referenced this pull request Jan 4, 2026
…n_grpc_e2e

- Add missing imports to vault_minimal_e2e.rs (TempDir, PathBuf, Arc, RuntimeConfig, etc.)
- Disable runplan_grpc_e2e.rs until tonic 0.12 UnixStream connector issue is resolved
- This test requires hyper 1.x compatibility layer which is currently not available
- Reference: hyperium/tonic#1483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export axum::Router

2 participants