fix(http1): use case-insensitive matching for trailer fields#4011
Merged
seanmonstar merged 3 commits intoFeb 6, 2026
Conversation
Trailer header values were stored as HeaderValue and compared against HeaderName, causing case mismatch. Convert to HeaderName during parsing to normalize case per RFC 9110. Closes hyperium#4010
Contributor
|
Oh, sorry, haven't seen you've already come up with a PR and made my own to address the issue: #4012 Feel free to close mine. |
Contributor
Author
|
Hey thanks for the reply. I'm happy to close mine and look for a new issue to tackle. Just let me know what works best for you! |
seanmonstar
reviewed
Feb 3, 2026
seanmonstar
left a comment
Member
There was a problem hiding this comment.
Thanks, I'm happy to merge this one. Could we pull in the integration tests from the other PR? I think that'd make us more robust.
Add tests to verify case-insensitive matching for trailer field names works correctly with titlecase headers like "Chunky-Trailer". Co-authored-by: Pavel Borzenkov <pavel@borzenkov.net>
Contributor
Author
|
Appreciate the review. I added the integration tests from #4012. Thank you @pborzenkov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trailer header values were stored as HeaderValue and compared against HeaderName, causing case mismatch. Convert to HeaderName during parsing to normalize case per RFC 9110.
Closes #4010