-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add HTTP1 server config for allowing multiple spaces in parsing #3923
Copy link
Copy link
Closed
Labels
A-http1Area: HTTP/1 specific.Area: HTTP/1 specific.A-serverArea: server.Area: server.C-featureCategory: feature. This is adding a new feature.Category: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.
Metadata
Metadata
Assignees
Labels
A-http1Area: HTTP/1 specific.Area: HTTP/1 specific.A-serverArea: server.Area: server.C-featureCategory: feature. This is adding a new feature.Category: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Is your feature request related to a problem? Please describe.
We have a situation that we want to allow request to have multi spaces as a request line delimiter.
However, I found that the parser config for server is not exposed to the server builder unlike client.
Because of this, there is no way to use Hyper server to support those use case even though httparse crate has a flag for that feature.
Describe the solution you'd like
Expose the parser config in the similar way as Hyper Client.
As it will be configurable in the builder, it will not break other existing server behavior.
Client side example code: https://code.amazon.com/packages/S3DataEngineHyper/blobs/62a7a6badaba2858361fdc633727a97aed4c8853/--/src/client/conn/http1.rs#L350
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.