fix(client): early server response shouldn't propagate NO_ERROR#3275
Merged
seanmonstar merged 2 commits intoJul 26, 2023
Merged
Conversation
Closes hyperium#2872 Added test is failing against version without these changes.
DDtKey
commented
Jul 23, 2023
| Some(Err(e)) => { | ||
| return match e.reason() { | ||
| // These reasons should cause stop of body reading, but don't fail it. | ||
| // The same logic as for `Read for H2Upgraded` is applied here. |
Contributor
Author
There was a problem hiding this comment.
I'm referring to this line here:
Line 296 in a45d5d5
And it makes sense in terms of protocol behavior for the reasons.
Both of them call the same operation (self.recv_stream.poll_data(cx)) and seems that logic should be the same. But we can make it more specific.
Contributor
Author
There was a problem hiding this comment.
Btw, an additional example from another lang & lib where it was also solved by avoiding error if response has been read: square/okhttp#6295
nox
approved these changes
Jul 26, 2023
nox
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me given we already do something similar for streams upgraded from HTTP/2.
seanmonstar
approved these changes
Jul 26, 2023
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
…rium#3275) Closes hyperium#2872 Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
seanmonstar
pushed a commit
that referenced
this pull request
Apr 22, 2026
…y response (#3998) This is the trailers variant of the fix for reading the body in #3275, so that it is possible to both attempt to read the body and the trailers when the server has sent a `RST_STREAM` with `NO_ERROR` after its response to indicate that the client should stop attempting to send it the body. I have added a trailers-only variant of `http2_responds_before_consuming_request_body` that fails without the fix, and also updated `http2_responds_before_consuming_request_body` to verify that it can check whether there are any trailers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2872
Added test is failing against the current version (before this fix)
Backport for
0.14.x: #3274