fix(DateField): handle too long and non-numeric input#1990
Merged
huntabyte merged 5 commits intoMar 30, 2026
Merged
Conversation
…ep focus on the input
🦋 Changeset detectedLatest commit: e193ee4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
…nput Use a flag-based approach with capture-phase keydown/keyup handlers to distinguish keyboard-initiated beforeinput events from browser-initiated ones (autocomplete, IME, etc.) on WebKit. Only prevent beforeinput when it was not triggered by a keyboard event.
1eb0d62 to
289d5ff
Compare
…n WebKit/Firefox WebKit and Firefox fire beforeinput on contenteditable elements even after keydown.preventDefault(), causing native text insertion to corrupt segment display. Prevent single-character and null-data beforeinput events while allowing multi-character insertText API calls through.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onbeforeinputevent handler to date field segments to prevent arbitrary text inputcontenteditable="true"for focus/keyboard handling, but relied solely ononkeydown+preventDefault()to block invalid inputkeydownprevention on contenteditableelements, allowing users to type letters or invalid values into date segments
Fix
Added
onbeforeinput: (e) => e.preventDefault()tosharedSegmentAttrs, which blocks all browser-native text insertionat the input pipeline level. This is safe because segment values are always managed programmatically through
updateSegment()and Svelte state — the browser never needs to insert text directly.