Skip to content

Fix lr_scheduler_parsing#41322

Merged
SunMarc merged 2 commits intomainfrom
fix-parsing
Oct 3, 2025
Merged

Fix lr_scheduler_parsing#41322
SunMarc merged 2 commits intomainfrom
fix-parsing

Conversation

@SunMarc
Copy link
Copy Markdown
Member

@SunMarc SunMarc commented Oct 3, 2025

What does this PR do?

This PR fixes lr_scheduler_kwargs type to Optional[Union[dict, str]] as HfArgumentParser doesn't handled well args that needs to parsed into dict. For now, it is better to just follow what is done for fsdp_config for example.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sounds good!

@SunMarc SunMarc merged commit 1bc75db into main Oct 3, 2025
26 checks passed
@SunMarc SunMarc deleted the fix-parsing branch October 3, 2025 15:51
yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Oct 4, 2025
@Rocketknight1 Rocketknight1 mentioned this pull request Oct 6, 2025
5 tasks
AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
taidopurason pushed a commit to taidopurason/transformers that referenced this pull request Nov 3, 2025
* fix

* fix

(cherry picked from commit 1bc75db)
@qgallouedec qgallouedec added the for patch Tag issues / labels that should be included in the next patch label Nov 12, 2025
vasqu pushed a commit that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for patch Tag issues / labels that should be included in the next patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants