[Add Mixtral] Adds support for the Mixtral MoE#27942
Merged
LysandreJik merged 111 commits intomainfrom Dec 11, 2023
Merged
Conversation
…ace/new-model-addition into add-mixtral-alternative
…ace/new-model-addition into add-mixtral-alternative
…ace/new-model-addition into add-mixtral-alternative
…ace/new-model-addition into add-mixtral-alternative
…ace/new-model-addition into add-mixtral-alternative
152334H
reviewed
Dec 11, 2023
LysandreJik
approved these changes
Dec 11, 2023
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Looks awesome! Thanks for the integration @ArthurZucker @younesbelkada, merge once you're ready and CI is green.
A few documentation things that we can improve on, but let's do that after it has landed in the lib.
| Tips: | ||
|
|
||
|
|
||
| - The model needs to be converted using the [conversion script](https://github.com/huggingface/transformers/blob/main/src/transformers/models/mixtral/convert_mixtral_weights_to_hf.py). |
Member
There was a problem hiding this comment.
Maybe not relevant once the weights are pushed to the Hub
Co-authored-by: Lysandre Debut <hi@lysand.re>
Co-authored-by: Lysandre Debut <hi@lysand.re>
Contributor
younesbelkada
left a comment
There was a problem hiding this comment.
A small nit on the conversion script!
|
Are there any other aux losses apart from the LM loss? |
Collaborator
Author
|
The auxiliary loss can be computed with |
narvind2003
reviewed
Dec 11, 2023
| @@ -1246,7 +1241,7 @@ def forward( | |||
|
|
|||
| aux_loss = None | |||
| if output_router_logits: | |||
There was a problem hiding this comment.
Setting output_router_logits = True should automatically add the aux_loss
iantbutler01
pushed a commit
to BismuthCloud/transformers
that referenced
this pull request
Dec 16, 2023
* up * up * test * logits ok * up * up * few fixes * conversion script * up * nits * nits * update * nuke * more updates * nites * fix many issues * nit * scatter * nit * nuke megablocks * nits * fix conversion script * nit * remove * nits * nit * update * oupsssss * change * nits device * nits * fixup * update * merge * add copied from * fix the copy mentions * update tests * more fixes * nits * conversion script * add parts of the readme * Update tests/models/mixtral/test_modeling_mixtral.py Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * new test + conversion script * Apply suggestions from code review Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com> * Apply suggestions from code review * fix * fix copies * fix copies * ooops * fix config * Apply suggestions from code review * fix nits * nit * add copies * add batched tests * docs * fix flash attention * let's add more verbose * add correct outputs * support router ouptus * ignore copies where needed * fix * cat list if list is given for now * nits * Update docs/source/en/model_doc/mixtral.md * finish router refactoring * fix forward * fix expected values * nits * fixup * fix * fix bug * fix * fix dtype mismatch * fix * grrr grrr I support item assignment * fix CI * docs * fixup * remove some copied form * fix weird diff * skip doctest fast on the config and modeling * mark that is supports flash attention in the doc * update * Update src/transformers/models/mixtral/modeling_mixtral.py Co-authored-by: Lysandre Debut <hi@lysand.re> * Update docs/source/en/model_doc/mixtral.md Co-authored-by: Lysandre Debut <hi@lysand.re> * revert router logits config issue * update doc accordingly * Update src/transformers/models/mixtral/convert_mixtral_weights_to_hf.py * nits * use torch testing asssert close * fixup * doc nits --------- Co-authored-by: younesbelkada <younesbelkada@gmail.com> Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com> Co-authored-by: Lysandre Debut <hi@lysand.re>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the latest MoE model from mistral AI