Fix iterable skip over full Arrow blocks#8236
Merged
Merged
Conversation
lhoestq
approved these changes
Jun 5, 2026
lhoestq
left a comment
Member
There was a problem hiding this comment.
lgtm ! applying a minor change for consistency with take()
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
IterableDataset.skip(n)for streaming datasets when the underlying iterable uses Arrow batches andnskips one or more complete Arrow blocks.Previously, after a full Arrow block was counted as skipped,
_iter_arrow()continued into the partial-slice branch and yielded rows from a block that should have been fully skipped.What was the issue?
SkipExamplesIterable._iter_arrow()handles skipping in two cases:The bug was that case 1 did not stop after marking the table as skipped. So the same table then fell through into case 2.
In other words, a table could first be counted as "already skipped", but then still be sliced and yielded.
For example, if Arrow tables have 4 rows each and we call
skip(6):[0, 1, 2, 3]and should be fully skipped[4, 5, 6, 7], so only[4, 5]should be skipped and[6, 7]should be yieldedBefore this PR, after table 1 was counted as skipped, the code kept processing table 1 and yielded part of it. This is why skipped rows could appear in the output.
This PR adds
continueafter a table is fully skipped, so the code moves directly to the next Arrow table.Tests
PYTHONPATH=src pytest tests/test_iterable_dataset.py::test_skip_arrow_examples_iterable -qThe regression test covers skipping within a block, exactly one block, across blocks, and beyond the dataset length.