Skip to content

feat(release): add support for monorepo architecture#263

Merged
neilime merged 1 commit intomainfrom
copilot/support-monorepo-architecture
Nov 26, 2025
Merged

feat(release): add support for monorepo architecture#263
neilime merged 1 commit intomainfrom
copilot/support-monorepo-architecture

Conversation

Copy link
Contributor

Copilot AI commented Nov 26, 2025

  • Understand the issue: Add working-directory input to support monorepo architecture
  • Analyze the current prepare-release.yml workflow structure
  • Run linter to ensure current state is working
  • Add working-directory input to the workflow
  • Update pull-request-labeler job to use working-directory with config-name
  • Update release-configuration job to use working-directory for CONFIG_PATH
  • Update the documentation (prepare-release.md)
  • Run linter to validate changes
  • Fix code review feedback: correct config-name path to be relative to .github directory
  • Add comments explaining path construction logic
  • Run security scan (no alerts found)
  • Address reviewer feedback (round 1):
    • Store config files in .github/release-configs/{slug}.yml instead of {working-directory}/.github/release-drafter.yml
    • Add include-paths to filter PRs to files in the specified working directory
    • Add support for feat! and type(scope)!: patterns (conventional commit breaking change)
  • Address reviewer feedback (round 2):
    • Add prepare job for config name computation to avoid duplication
    • Improve slugify method to handle spaces and special characters
    • Add include-paths input for custom additional paths
    • Include current workflow file in include-paths for monorepo context
  • Address code review suggestions:
    • Add error details to warning message for JSON parse failures
    • Add fallback handling for GITHUB_WORKFLOW_REF environment variable
  • Address reviewer feedback (round 3):
    • Add condition to prepare job to only run for pull_request or push to default branch
    • Simplify pull-request-labeler condition syntax
    • Use core.setFailed() instead of warning for JSON parse errors
    • Add include-paths section when additionalPaths is not empty even without working-directory
Original prompt

On prepare-release.yml, This workflow should support "monorepo" architecture.

User can specify sub folder as working-directory


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add support for monorepo architecture in prepare-release.yml feat: add working-directory input for monorepo support in prepare-release workflow Nov 26, 2025
Copilot AI requested a review from neilime November 26, 2025 06:52
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Handle feedbacks

Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot Handle feedbacks

All feedback addressed in commit 9216ff2:

  • Config files now stored in .github/release-configs/{slug}.yml
  • Added include-paths section for monorepo filtering
  • Added support for feat!: and type(scope)!: conventional commit patterns

Copilot AI requested a review from neilime November 26, 2025 08:36
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot handle feedbacks

All feedback addressed in commit b32bca8:

  • Created prepare job for config name computation (no duplication)
  • Improved slugify to handle spaces and special characters
  • Added include-paths input for custom additional paths
  • Current workflow file is now included in include-paths for monorepo context

Copilot AI requested a review from neilime November 26, 2025 09:08
Copy link
Member

@neilime neilime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot handle feedbacks

Copy link
Contributor Author

Copilot AI commented Nov 26, 2025

@copilot handle feedbacks

All feedback addressed in commit ec556bd:

  • Added condition to prepare job for PR or push to default branch events
  • Simplified pull-request-labeler condition syntax
  • Changed to core.setFailed() for JSON parse errors
  • Added include-paths section when additionalPaths is not empty (even without working-directory)

Copilot AI requested a review from neilime November 26, 2025 09:23
@neilime neilime force-pushed the copilot/support-monorepo-architecture branch from ec556bd to 7f80f6c Compare November 26, 2025 09:42
@neilime neilime changed the title feat: add working-directory input for monorepo support in prepare-release workflow feat(release): add support for monorepo architecture Nov 26, 2025
@neilime neilime marked this pull request as ready for review November 26, 2025 09:43
@neilime neilime merged commit 418e2c3 into main Nov 26, 2025
23 checks passed
@neilime neilime deleted the copilot/support-monorepo-architecture branch November 26, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants