Make the macOS regex allow macosx#80
Merged
autarch merged 1 commit intohouseabsolute:masterfrom Dec 23, 2024
Merged
Conversation
bartsmykla
reviewed
Dec 18, 2024
Member
|
Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:
Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1. Thanks again for your contribution! |
Contributor
Author
|
Hi! This PR contains a small amount of work, so I believe the first option works well. Feel free to handle it in a way that’s most convenient for you. 👌 UPD: |
defd597 to
bfa308d
Compare
autarch
approved these changes
Dec 23, 2024
macosx
Member
|
Thanks again for the PR! |
Member
|
This was included in the v0.3.0 release, which just went out a moment ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using build triple names for release assets, there is an issue with macOS assets because the OS name in Swift’s build triples is macosx instead of macos.
Sources for reference:
• List of possible triples in Swift tests
• Article on building Swift executables using triples
• Example of assets named by triples