Skip to content

test(router): fix Simple capturing group test#4838

Merged
yusukebe merged 1 commit intomainfrom
test/router-proper-test
Mar 30, 2026
Merged

test(router): fix Simple capturing group test#4838
yusukebe merged 1 commit intomainfrom
test/router-proper-test

Conversation

@yusukebe
Copy link
Copy Markdown
Member

@yusukebe yusukebe commented Mar 30, 2026 •
edited
Loading

Fixes #1837

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Bundle size check

main (e1ae0eb) #4838 (4587337) +/-
Bundle Size (B) 18,489B 18,489B 0B
Bundle Size (KB) 18.06K 18.06K 0K

Compiler Diagnostics (tsc)

main (e1ae0eb) #4838 (4587337) +/-
Files 229 229 0
Lines 146,731 146,731 0
Identifiers 124,420 124,420 0
Symbols 150,583 150,583 0
Types 157,112 157,112 0
Instantiations 401,446 401,446 0
Memory used 252,256K 254,610K 2,354K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.71s 0.73s 0.02s
Bind time 0.28s 0.28s 0s
Check time 1.44s 1.49s 0.05s
Emit time 0.01s 0.01s 0s
Total time 2.45s 2.51s 0.06s

Compiler Diagnostics (typescript-go)

main (e1ae0eb) #4838 (4587337) +/-
Files 229 229 0
Lines 150,912 150,912 0
Identifiers 125,098 125,098 0
Symbols 190,886 190,886 0
Types 255,496 255,496 0
Instantiations 608,997 608,997 0
Memory used 162,061K 162,135K 74K
Memory allocs 1,768,270 1,765,757 -2,513
Config time 0.001s 0.001s 0s
BuildInfo read time 0.001s 0.001s 0s
Parse time 0.104s 0.098s -0.006s
Bind time 0s 0s 0s
Check time 0.472s 0.46s -0.012s
Emit time 0.004s 0.004s 0s
Changes compute time 0.04s 0.037s -0.003s
Total time 0.656s 0.636s -0.02s

Reported by octocov

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 32,540.27 44,470.73 29,238.29 23,911.80
hono (current) bun 33,382.91 45,503.02 30,301.47 24,344.23
Change +2.59% +2.32% +3.64% +1.81%

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.84%. Comparing base (e1ae0eb) to head (505bccf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4838   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files         177      177           
  Lines       11643    11643           
  Branches     3469     3468    -1     
=======================================
  Hits        10810    10810           
  Misses        832      832           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe merged commit 018277e into main Mar 30, 2026
20 checks passed
@yusukebe yusukebe deleted the test/router-proper-test branch March 30, 2026 10:17
@yusukebe yusukebe mentioned this pull request Mar 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capture Group Tests Appear to use non-capture group and are duplicate of non-capture group tests.

1 participant

@yusukebe