Skip to content

feat: switched from tiged to giget#63

Merged
yusukebe merged 3 commits intohonojs:mainfrom
MathurAditya724:main
Aug 3, 2024
Merged

feat: switched from tiged to giget#63
yusukebe merged 3 commits intohonojs:mainfrom
MathurAditya724:main

Conversation

@MathurAditya724
Copy link
Copy Markdown
Contributor

Closes #50

  • Removed tiged
  • Added giget
  • Replaced tiged function with downloadTemplate
  • Minor string formatting change

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice!

@MathurAditya724
Copy link
Copy Markdown
Contributor Author

MathurAditya724 commented Aug 1, 2024

I do have 1 suggestion in place of keeping offline (prev cache) false all the time, we can give this control to the user by --offline=false. This can be a separate PR because we will need to introduce something like commander, which can help keep track of these params as well as the show --help options.

Similiar to #61

@MathurAditya724 MathurAditya724 mentioned this pull request Aug 2, 2024
Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Member

yusukebe commented Aug 3, 2024

Hi @MathurAditya724

Awesome work! I've tried it on my machine; it works well. The fantastic thing is that the time spent Cloning the template has been shorter than the current one. It will be fast! I'll merge this now. Thank you very much.

I do have 1 suggestion in place of keeping offline (prev cache) false all the time, we can give this control to the user by --offline=false. This can be a separate PR because we will need to introduce something like commander, which can help keep track of these params as well as the show --help options.

Also, I like this idea.

@yusukebe yusukebe merged commit 929643b into honojs:main Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop using tiged

2 participants