Merged
Conversation
akhtarmdsaad
referenced
this pull request
in akhtarmdsaad/highlight.js
Sep 19, 2023
joshgoebel
reviewed
Sep 21, 2023
joshgoebel
reviewed
Sep 21, 2023
joshgoebel
reviewed
Sep 21, 2023
joshgoebel
reviewed
Sep 21, 2023
4004f85 to
b894ee9
Compare
joshgoebel
approved these changes
Oct 8, 2023
Build Size ReportChanges to minified artifacts in 8 files changedTotal change +11 B View Changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed CSS variable detection Syntax
It resolves the issue #3823
Changes
There is a bug in src/languages/lib/css-shared.js file.
adding an underscore( _ ) in CSS_VARIABLES fixes the problem.
Code Before:
CSS_VARIABLE: {
className: "attr",
begin: /--[A-Za-z][A-Za-z0-9_-]*/
}
Code After:
CSS_VARIABLE: {
className: "attr",
begin: /--[A-Za-z_][A-Za-z0-9_-]*/
//Look change in ^ here
}
Checklist
CHANGES.md