Skip to content

fix: improve invalid input error#3679

Merged
mrlubos merged 1 commit into
mainfrom
fix/input-error-log
Apr 2, 2026
Merged

fix: improve invalid input error#3679
mrlubos merged 1 commit into
mainfrom
fix/input-error-log

Conversation

@mrlubos

@mrlubos mrlubos commented Apr 2, 2026

Copy link
Copy Markdown
Member

Closes #3659

@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Apr 2, 2026

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot

changeset-bot Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b643d7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@hey-api/openapi-ts Patch
@hey-api/shared Patch
@hey-api/json-schema-ref-parser Patch
@hey-api/openapi-python Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Apr 2, 2026 11:36pm

Request Review

@mrlubos mrlubos force-pushed the fix/input-error-log branch from 3c7405f to a782953 Compare April 2, 2026 23:24
@mrlubos mrlubos marked this pull request as ready for review April 2, 2026 23:24
@pullfrog

pullfrog Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewed PR #3679. Submitted one actionable comment: shouldReportCrash now excludes all JobError instances (not just input-related ones), which suppresses the interactive crash-report prompt for genuine plugin/runtime crashes.

Task list (4/4 completed)
  • Read the full diff to understand all changes
  • Read source files for context on changed areas
  • Trace data flow and verify correctness
  • Draft and submit review

Pullfrog  ｜ View workflow run ｜ Triggered by Pullfrog ｜ 𝕏

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. bug 🔥 Broken or incorrect behavior. labels Apr 2, 2026
@pkg-pr-new

pkg-pr-new Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@hey-api/codegen-core

npm i https://pkg.pr.new/@hey-api/codegen-core@3679

@hey-api/json-schema-ref-parser

npm i https://pkg.pr.new/@hey-api/json-schema-ref-parser@3679

@hey-api/nuxt

npm i https://pkg.pr.new/@hey-api/nuxt@3679

@hey-api/openapi-ts

npm i https://pkg.pr.new/@hey-api/openapi-ts@3679

@hey-api/shared

npm i https://pkg.pr.new/@hey-api/shared@3679

@hey-api/spec-types

npm i https://pkg.pr.new/@hey-api/spec-types@3679

@hey-api/types

npm i https://pkg.pr.new/@hey-api/types@3679

@hey-api/vite-plugin

npm i https://pkg.pr.new/@hey-api/vite-plugin@3679

commit: b643d7d

@codecov

codecov Bot commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 18.96552% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.31%. Comparing base (5e1eaea) to head (b643d7d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/shared/src/error.ts 13.51% 25 Missing and 7 partials ⚠️
packages/openapi-ts/src/createClient.ts 37.50% 6 Missing and 4 partials ⚠️
packages/openapi-ts/src/generate.ts 0.00% 1 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3679      +/-   ##
==========================================
- Coverage   38.38%   38.31%   -0.07%     
==========================================
  Files         520      520              
  Lines       19228    19275      +47     
  Branches     5689     5706      +17     
==========================================
+ Hits         7380     7385       +5     
- Misses       9587     9617      +30     
- Partials     2261     2273      +12
Flag Coverage Δ
unittests 38.31% <18.96%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pullfrog[bot]
pullfrog Bot reviewed Apr 2, 2026
View reviewed changes

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-structured change. One functional concern about shouldReportCrash now suppressing crash-report prompts for all JobError instances, not just input-related ones.

Pullfrog  ｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ 𝕏

Comment thread packages/shared/src/error.ts Outdated
@mrlubos mrlubos force-pushed the fix/input-error-log branch from a782953 to b643d7d Compare April 2, 2026 23:35
@mrlubos mrlubos merged commit dfbd9a1 into main Apr 2, 2026
10 of 12 checks passed
@mrlubos mrlubos deleted the fix/input-error-log branch April 2, 2026 23:40
@hey-api hey-api Bot mentioned this pull request Apr 2, 2026
Closed
@hey-api hey-api Bot mentioned this pull request Apr 13, 2026
Merged
@pullfrog pullfrog Bot mentioned this pull request Jun 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pullfrog pullfrog[bot] pullfrog[bot] left review comments

Assignees

No one assigned

Labels

bug 🔥 Broken or incorrect behavior. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable crash report for not found input

1 participant

@mrlubos