Skip to content

fix: handle discriminators in experimental parser#1267

Merged
mrlubos merged 1 commit into
mainfrom
fix/experimental-parser-discriminator
Nov 10, 2024
Merged

fix: handle discriminators in experimental parser#1267
mrlubos merged 1 commit into
mainfrom
fix/experimental-parser-discriminator

Conversation

@mrlubos

@mrlubos mrlubos commented Nov 10, 2024

Copy link
Copy Markdown
Member

Closes #993

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot

changeset-bot Bot commented Nov 10, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ff3aa4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Nov 10, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 9:01pm

@mrlubos mrlubos marked this pull request as ready for review November 10, 2024 20:58
@codecov

codecov Bot commented Nov 10, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 52.88136% with 139 lines in your changes missing coverage. Please review.

Project coverage is 67.56%. Comparing base (04c88dd) to head (ff3aa4a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/openApi/3.0.x/parser/schema.ts 9.48% 105 Missing ⚠️
...ages/openapi-ts/src/openApi/3.1.x/parser/schema.ts 76.06% 28 Missing ⚠️
.../openapi-ts/src/plugins/@hey-api/schemas/plugin.ts 50.00% 3 Missing ⚠️
...enapi-ts/src/openApi/shared/utils/discriminator.ts 85.71% 2 Missing ⚠️
...kages/openapi-ts/src/openApi/3.0.x/parser/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1267      +/-   ##
==========================================
- Coverage   67.63%   67.56%   -0.08%     
==========================================
  Files         132      133       +1     
  Lines       19684    19841     +157     
  Branches     1775     1784       +9     
==========================================
+ Hits        13314    13405      +91     
- Misses       6366     6432      +66     
  Partials        4        4              
Flag Coverage Δ
unittests 67.56% <52.88%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos force-pushed the fix/experimental-parser-discriminator branch from 5b684d2 to ff3aa4a Compare November 10, 2024 21:01
@mrlubos mrlubos merged commit 8b46fe6 into main Nov 10, 2024
@mrlubos mrlubos deleted the fix/experimental-parser-discriminator branch November 10, 2024 21:09
@github-actions github-actions Bot mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discriminator in OpenApi schema not recognized correctly

1 participant