perf: reduce ObjectAssign overhead#5698
Merged
D-Sketon merged 2 commits intohexojs:masterfrom Oct 3, 2025
Merged
Conversation
How to testgit clone -b perf/8.0.0-6 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 18185497716Details
💛 - Coveralls |
SukkaW
approved these changes
Oct 3, 2025
Member
There was a problem hiding this comment.
Basically, Object.assign is just reading and assigning properties and values one by one, that's why the following use case of Object.assign also works:
Object.assign(htmlElement.style, { fontSize: '12px', color: 'navy' });
// This is basically the same as
htmlElement.style.fontSize = '12px';
htmlElement.style.color = 'navy';
Object.assign(function() {}, { extraPropOnFunction });
// This is basically the same as
(function() {}).extraPropOnFunction = extraPropOnFunction;Thus, Object.assign on a plain object will also face the same Monomorphism JIT issue of V8. If we predefine the shape of the object, V8 will have to de-optimize later. But if we don't define the shape, V8 will determine the shape itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Interestingly, just modifying this single line can significantly reduce the overhead of ObjectAssign.
Screenshots
8x hexo-many-posts + hexo-theme-reimu
before

after

Pull request tasks