refactor(moment): remove unused timezone setting#5654
Merged
stevenjoezhang merged 3 commits intomasterfrom Apr 22, 2025
Merged
Conversation
How to testgit clone -b timezone https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 14575535317Details
💛 - Coveralls |
yoshinorin
reviewed
Apr 21, 2025
Member
yoshinorin
left a comment
There was a problem hiding this comment.
Regarding the title of the PR, shouldn't it be refactor instead of feat? 🤔
2076171 to
5353932
Compare
SukkaW
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
ctx.configinlib/models/page.tsandlib/models/post.tsare Hexo default config, instead of variables from_config.yml.Removing the code only affects its own unit tests, no other functionalities are affected.
I propose to remove it because it's not used and may cause confusion when developing timezone-related features.
timezonefunction incommon.tstoadjustDateForTimezone, to make the name more precise.Screenshots
Pull request tasks