Conversation
How to testgit clone -b timestamp https://github.com/hexojs/hexo.git
cd hexo
npm install
npm test |
f819977 to
a13326d
Compare
uiolee
commented
Jan 9, 2025
This comment was marked as outdated.
This comment was marked as outdated.
SukkaW
previously approved these changes
Jan 9, 2025
Pull Request Test Coverage Report for Build 12764580920Details
💛 - Coveralls |
SukkaW
reviewed
Jan 14, 2025
Member
SukkaW
left a comment
There was a problem hiding this comment.
Should we add :update_timestamp as well IMHO?
Member
Author
I'm not sure if there is such a use case. But generally speaking, |
4 tasks
SukkaW
approved these changes
Jan 15, 2025
SukkaW
reviewed
Jan 15, 2025
Comment on lines
35
to
40
| second: date.format('ss'), | ||
| i_month: date.format('M'), | ||
| i_day: date.format('D'), | ||
| timestamp: date.format('X'), | ||
| hash, | ||
| category: config.default_category |
Member
There was a problem hiding this comment.
Just a thought, we could use an approach like the following to only calculate the permalink value when needed, and cache it afterward:
function defineLazyProperty(object, propertyName, valueGetter) {
const define = value => Object.defineProperty(object, propertyName, {value, enumerable: true, writable: true});
Object.defineProperty(object, propertyName, {
configurable: true, enumerable: true,
get() {
const result = valueGetter();
define(result);
return result;
},
set: define
});
return object;
}
const permalink = {};
defineLazyProperty(permalink, 'second', () => date.format('ss'));
// ...
defineLazyProperty(permalink, 'timestamp', () => date.format('X'));Or we can use Map instead of object here.
We can do this in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
fix #5586
Screenshots
Pull request tasks
:timestampsite#2326