perf(external_link): optimize external link filter#5598
Merged
uiolee merged 3 commits intohexojs:masterfrom Jan 9, 2025
Merged
perf(external_link): optimize external link filter#5598uiolee merged 3 commits intohexojs:masterfrom
uiolee merged 3 commits intohexojs:masterfrom
Conversation
How to testgit clone -b perf/externalLinkFilter https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
SukkaW
approved these changes
Dec 29, 2024
yoshinorin
approved these changes
Dec 31, 2024
uiolee
approved these changes
Jan 2, 2025
Member
|
@D-Sketon BTW We can probably find more similar patterns in Hexo's codebase that can also be refactored. |
Pull Request Test Coverage Report for Build 12654113964Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
optimize externalLinkFilter
Screenshots
before
after
Pull request tasks