Updating link handling#31041
Merged
robertsirc merged 2 commits intohelm:release-3.17from Jul 15, 2025
Merged
Conversation
Backport of helm@4b8e610 Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
|
This would be a really welcome change. I was trying to address this in Kueue and I realize its next to impossible to carry this to projects that depend on earlier k8s versions. For these branch, we have 0.32 dependencies and in order to carry this, we would have to update all of k8s. |
Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
8fef6f8 to
0e59b9e
Compare
Author
|
fixed linter issue |
TerryHowe
reviewed
Jul 14, 2025
Contributor
TerryHowe
left a comment
There was a problem hiding this comment.
/lgtm
I'd never written code in go to check for symbolic links and info.Mode()&os.ModeSymlink != 0 is pretty terrible. PR looks good though, thanks!
Author
|
@robertsirc thanks! final step in making this available is tagging 595a05d with tag |
Member
|
No it's all on us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport of 4b8e610 to release-3.17 hopefully to be cut into 3.17.4
If applicable:
docs neededlabel should be applied if so)