Skip to content
This repository was archived by the owner on Jan 5, 2024. It is now read-only.

Add suport for GHC nightlies via GHCup#279

Merged
andreasabel merged 3 commits intohaskell:mainfrom
wismill:wip/ghc-nightlies
Aug 8, 2023
Merged

Add suport for GHC nightlies via GHCup#279
andreasabel merged 3 commits intohaskell:mainfrom
wismill:wip/ghc-nightlies

Conversation

@wismill
Copy link
Copy Markdown
Contributor

@wismill wismill commented Jul 4, 2023 •
edited by andreasabel
Loading

Available since GHCup 0.1.19.3.

Related issues:

Closes #93.
Closes #137.

@wismill wismill force-pushed the wip/ghc-nightlies branch from 75021a6 to 53f6a3a Compare July 4, 2023 17:12
@wismill
Copy link
Copy Markdown
Contributor Author

wismill commented Jul 4, 2023 •
edited
Loading

Currently failing on the expected GHC version check. We have no way to know in advance this version!

Should we check only the A.B in A.B.C GHC version? This will require to set a new parameter after each GHC release.

@wismill wismill force-pushed the wip/ghc-nightlies branch 2 times, most recently from 76b1446 to fccd6d7 Compare July 4, 2023 18:52
@wismill wismill force-pushed the wip/ghc-nightlies branch 2 times, most recently from ce3ea5d to 45bc95a Compare July 4, 2023 20:37
@wismill wismill force-pushed the wip/ghc-nightlies branch from 45bc95a to 33cf5c0 Compare July 4, 2023 20:43
@wismill
Copy link
Copy Markdown
Contributor Author

wismill commented Jul 4, 2023

I found a way to check the exact version of the latest GHC nightly, but it seems convoluted.

Also, why steps.setup.outputs.ghcup-release-channel is not set when matrix.ghcup_release_channel is?

andreasabel
andreasabel reviewed Jul 5, 2023
View reviewed changes
Comment thread .github/workflows/workflow.yml Outdated
if [[ "${{ steps.setup.outputs.ghc-version }}" == "latest-nightly" ]]
then
# TODO: Shouldn't we use steps.setup.outputs.ghcup-release-channel?
# Why is empty?
Copy link
Copy Markdown
Member

@andreasabel andreasabel Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghcup-release-channel is not an output of the setup action, you can see inputs and outputs of this action here: https://github.com/haskell/actions/blob/fc675398fab930927d01e9c00eee89066aa2ca12/setup/action.yml

Copy link
Copy Markdown
Contributor Author

@wismill wismill Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. So the current use of matrix.ghcup_release_channel is OK I guess?

@wismill wismill marked this pull request as ready for review July 5, 2023 11:01
@andreasabel andreasabel added this to the 2.5.0 milestone Aug 8, 2023
andreasabel
andreasabel approved these changes Aug 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, apologies for the delay!

@andreasabel andreasabel merged commit 3501ebb into haskell:main Aug 8, 2023
@andreasabel andreasabel self-assigned this Aug 8, 2023
@andreasabel andreasabel removed this from the 2.5.0 milestone Aug 8, 2023
@andreasabel
Copy link
Copy Markdown
Member

andreasabel commented Aug 8, 2023

Released as v2.4.6.

@andreasabel andreasabel added the re: ghc head Concerning installation of GHC head label Aug 8, 2023
This was referenced Aug 8, 2023
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@andreasabel andreasabel andreasabel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andreasabel andreasabel

Labels

re: ghc head Concerning installation of GHC head

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure trying to install ghc head Unable to install GHC head version

2 participants

@wismill @andreasabel