Merged
Conversation
nywilken
approved these changes
Aug 1, 2023
Contributor
nywilken
left a comment
There was a problem hiding this comment.
This looks good. Please rebase to fix conflicts.
Since the SDK in v0.5.0 contains a release statement in its go.mod, this makes it impossible to go install packer-sdc from a plugin. Since those plugins rely on their Makefile to do this, we cannot change them all at once, so we fixed the problem in the SDK code itself, and v0.5.0 is broken, so we retract it in this commit.
Since the latest comment introduces a retract statement, with a comment that contains `replace', the check failed, so we improve it to only consider `replace' if they're the first thing on a line.
c5e416b to
6c36c24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the SDK in v0.5.0 contains a release statement in its go.mod, this makes it impossible to go install packer-sdc from a plugin.
Since those plugins rely on their Makefile to do this, we cannot change them all at once, so we fixed the problem in the SDK code itself, and v0.5.0 is broken, so we retract it in this commit.