Skip to content

packer-sdc: Remove version specific Go code#198

Merged
nywilken merged 3 commits intomainfrom
remove-version-specific-go-code
Aug 1, 2023
Merged

packer-sdc: Remove version specific Go code#198
nywilken merged 3 commits intomainfrom
remove-version-specific-go-code

Conversation

@nywilken
Copy link
Copy Markdown
Contributor

@nywilken nywilken commented Aug 1, 2023

  • Remove use of Go 1.20 language features
  • Add matrix builds for supported Go versions

Branched from #197

@nywilken nywilken changed the base branch from main to fix_replace_go_mod August 1, 2023 00:47
@nywilken nywilken changed the title remove version specific go code packer-sdc: Remove version specific Go code Aug 1, 2023
@nywilken nywilken force-pushed the remove-version-specific-go-code branch 3 times, most recently from 8ea9f9d to 84ef29b Compare August 1, 2023 00:57
@nywilken nywilken changed the base branch from fix_replace_go_mod to main August 1, 2023 01:00
@nywilken nywilken force-pushed the remove-version-specific-go-code branch 4 times, most recently from 274a334 to c0e0936 Compare August 1, 2023 14:23
@nywilken nywilken marked this pull request as ready for review August 1, 2023 14:29
@nywilken nywilken requested a review from a team as a code owner August 1, 2023 14:29
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nywilken nywilken force-pushed the remove-version-specific-go-code branch from c0e0936 to ab599bd Compare August 1, 2023 14:46
Wilken Rivera added 3 commits August 1, 2023 13:08
In go 1.19 changes to go fmt resulted in slightly different comment formatting for generated code.
Bumping to Go 1.19 ensures that the correct version of Go tooling is used formatting the generated code.
@nywilken nywilken force-pushed the remove-version-specific-go-code branch from ab599bd to 5cadcd3 Compare August 1, 2023 17:08
@nywilken nywilken added the bug Something isn't working label Aug 1, 2023
@nywilken nywilken merged commit 9be5b0f into main Aug 1, 2023
@nywilken nywilken deleted the remove-version-specific-go-code branch August 1, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants