Skip to content

Fix menu boot command vnc key stroke#184

Merged
lbajolet-hashicorp merged 6 commits intohashicorp:mainfrom
korli:main
May 25, 2023
Merged

Fix menu boot command vnc key stroke#184
lbajolet-hashicorp merged 6 commits intohashicorp:mainfrom
korli:main

Conversation

@korli
Copy link
Copy Markdown
Contributor

@korli korli commented May 25, 2023

<menu> would output individual keys instead of the menu special key.

@korli korli requested a review from a team as a code owner May 25, 2023 06:16
@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented May 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch on that one @korli, thanks for the fix!

@korli
Copy link
Copy Markdown
Contributor Author

korli commented May 25, 2023

LGTM, good catch on that one @korli, thanks for the fix!

Good! Let me know if commits need to be squashed.

@lbajolet-hashicorp
Copy link
Copy Markdown
Contributor

No need to worry about that, Github can do it for us, I'm merging this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants